[Insight-developers] Extrapolating vector images

Luis Ibanez luis.ibanez at kitware.com
Fri Sep 3 12:56:47 EDT 2010 

Bill,

good point.

I believe that the compilers that didn't allow
initializing zero-length arrays were BCC55 and VS6...

that said,
I agree with you,
the Dashboard is the only way to tell for sure...


    Luis


----------------------------------------------------------------
On Fri, Sep 3, 2010 at 12:52 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Very nice. It will be interesting to see if this works for all of our
> compilers. If it does, I expect that there are other filters that can
> benefit.
>
> Bill
>
> On Fri, Sep 3, 2010 at 12:49 PM, Luis Ibanez <luis.ibanez at kitware.com>
> wrote:
> > Hi Tom,
> >
> > Thanks for creating and sharing the patch.
> >
> > I verified the in this experimental build:
> > http://www.cdash.org/CDash/buildSummary.php?buildid=711841
> >
> > (no tests failed due to the patch,
> >  although we have other tests pending fixes...)
> >
> > and have pushed your patch to Gerrit:
> > http://review.source.kitware.com/#change,37
> >
> > and marked it as verified and approved.
> >
> > Git's magic ensures that your authorship of
> > the patch is preserved in the commit message.
> >
> >
> >    Thanks
> >
> >
> >           Luis
> >
> >
> >
> -----------------------------------------------------------------------------
> > On Mon, Aug 30, 2010 at 10:39 AM, Tom Vercauteren <
> tom.vercauteren at m4x.org>
> > wrote:
> >>
> >> Thanks Kwame!
> >>
> >> Luis and Bill: I haven' caught up with git yet so please excuse me if
> >> this is not the right way to do.
> >>
> >> Attached is a patch for this bug. I used the procedure from here:
> >> http://www.itk.org/Wiki/Git/Publish#Patches
> >>
> >> I went rather flawlessly. I just add to fetch the commit hooks bas
> >> proposed after typing my first "git commit".
> >>
> >> Hope this helps,
> >> Tom
> >>
> >> On Mon, Aug 30, 2010 at 15:39, Kwame Kutten <kkutten1 at jhmi.edu> wrote:
> >> > Ok, I submitted a report:
> >> >
> >> > http://www.itk.org/Bug/view.php?id=11185
> >> >
> >> > ----- Original Message -----
> >> > From: Bill Lorensen <bill.lorensen at gmail.com>
> >> > Date: Monday, August 30, 2010 7:38 am
> >> > Subject: Re: [Insight-developers] Extrapolating vector images
> >> > To: Tom Vercauteren <tom.vercauteren at m4x.org>
> >> > Cc: Kwame Kutten <kkutten1 at jhmi.edu>, Luis Ibanez
> >> > <luis.ibanez at kitware.com>, insight-developers at itk.org
> >> >
> >> >
> >> >> I agree with Tom. Most if not all of the itkVectorXXX classes are
> >> >> candidates for removal (maybe not actually removed, but made trivial
> >> >> subclasses of their non-vector relatives.)
> >> >>
> >> >> Bill
> >> >>
> >> >> On Mon, Aug 30, 2010 at 7:11 AM, Tom Vercauteren
> >> >> <tom.vercauteren at m4x.org> wrote:
> >> >> > Hi Kwame and Luis,
> >> >> >
> >> >> > My feeling is that the ExtrapolateImageFunction should work with
> >> >> > vector images. If not, I would consider this to be a bug.
> >> >> >
> >> >> > As far as I understand it, the "Vector" versions of the
> >> >> > Interpolate/ExtrapolateImageFunctions only exist for historical
> >> >> > reasons (lack of partial template specialization on VS6). Now that
> >> >> > VS6
> >> >> > is gone, I'd rather get rid of all these "vector" classes as
> proposed
> >> >> > in the ITK 4.0 wish list:
> >> >> >
> >> >> >
> >> >> > Just to make my point, you may look at the
> >> >> > LinearInterpolateImageFunctionTest unit test that uses the standard
> >> >> > LinearInterpolateImageFunction to interpolate vector images:
> >> >> >
> >> >> >
> >> >> > Kwame: If anything really forbids the use of vector images in
> >> >> > ExtrapolateImageFunction, could you please file a bug report:
> >> >> >
> >> >> >
> >> >> > Thanks,
> >> >> > Tom
> >> >> >
> >> >> > On Sat, Aug 28, 2010 at 22:04, Luis Ibanez <
> luis.ibanez at kitware.com>
> >> >> wrote:
> >> >> >> Hi Kwame,
> >> >> >>
> >> >> >>
> >> >> >> Great,
> >> >> >>
> >> >> >> I hope you are planning on submitting
> >> >> >> this code to the Insight Journal.
> >> >> >>
> >> >> >>
> >> >> >>      Thanks
> >> >> >>
> >> >> >>           Luis
> >> >> >>
> >> >> >> ------------------------------
> >> >> >> On Sat, Aug 28, 2010 at 2:54 PM, Kwame Kutten <kkutten1 at jhmi.edu>
> >> >> >> wrote:
> >> >> >>>
> >> >> >>> I've just finished doing that (See attached file)
> >> >> >>>
> >> >> >>> Thanks for your help.
> >> >> >>>
> >> >> >>> ----- Original Message -----
> >> >> >>> From: Luis Ibanez <luis.ibanez at kitware.com>
> >> >> >>> Date: Saturday, August 28, 2010 2:02 pm
> >> >> >>> Subject: Re: [Insight-developers] Extrapolating vector images
> >> >> >>> To: Kwame Kutten <kkutten1 at jhmi.edu>
> >> >> >>> Cc: insight-developers at itk.org
> >> >> >>>
> >> >> >>>
> >> >> >>> > Hi Kwame,
> >> >> >>> >
> >> >> >>> > I would think that you should  write a class
> >> >> >>> >
> >> >> >>> >      itkVectorExtrapolateImageFunction
> >> >> >>> >
> >> >> >>> >
> >> >> >>> > similar to the current
> >> >> >>> >
> >> >> >>> >      itkVectorInterpolateImageFunction
> >> >> >>> >
> >> >> >>> >
> >> >> >>> >
> >> >> >>> >
> >> >> >>> >     Luis
> >> >> >>> >
> >> >> >>> >
> >> >> >>> > -------------------------------
> >> >> >>> > On Sat, Aug 28, 2010 at 11:04 AM, Kwame Kutten
> >> >> >>> > <kkutten1 at jhmi.edu>
> >> >> >>> > wrote:
> >> >> >>> >
> >> >> >>> > > I've written some new image extrapolators
> >> >> >>> > > (ConstantExtrapolateImageFunction
> >> >> >>> > > and PeriodicExtrapolateImageFunction) derived from the
> >> >> >>> > > ExtrapolateImageFunction class template.  They work with
> scaler
> >> >> >>> > images but
> >> >> >>> > > will not accept vector images because the base class was
> >> >> >>> > > designed
> >> >> >>> > for scalar
> >> >> >>> > > images (
> >> >> >>> > >
> >> >> >>> > >
> >> >> >>> > > Is there a way to modify the ExtrapolateImageFunction to work
> >> >> with
> >> >> >>> > > vector
> >> >> >>> > > images, or should I write a new vector-specific class (e.g.
> >> >> >>> > > ExtrapolateVectorImageFunction ) ?
> >> >> >>> > >
> >> >> >>> > > Thanks
> >> >> >>> > > _______________________________________________
> >> >> >>> > > Powered by www.kitware.com
> >> >> >>> > >
> >> >> >>> > > Visit other Kitware open-source projects at
> >> >> >>> > >
> >> >> >>> > >
> >> >> >>> > > Kitware offers ITK Training Courses, for more information
> >> >> >>> > > visit:
> >> >> >>> > >
> >> >> >>> > >
> >> >> >>> > > Please keep messages on-topic and check the ITK FAQ at:
> >> >> >>> > >
> >> >> >>> > >
> >> >> >>> > > Follow this link to subscribe/unsubscribe:
> >> >> >>> > >
> >> >> >>> > >
> >> >> >>
> >> >> >>
> >> >> >> _______________________________________________
> >> >> >> Powered by www.kitware.com
> >> >> >>
> >> >> >> Visit other Kitware open-source projects at
> >> >> >>
> >> >> >>
> >> >> >> Kitware offers ITK Training Courses, for more information visit:
> >> >> >>
> >> >> >>
> >> >> >> Please keep messages on-topic and check the ITK FAQ at:
> >> >> >>
> >> >> >>
> >> >> >> Follow this link to subscribe/unsubscribe:
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> > _______________________________________________
> >> >> > Powered by www.kitware.com
> >> >> >
> >> >> > Visit other Kitware open-source projects at
> >> >> >
> >> >> >
> >> >> > Kitware offers ITK Training Courses, for more information visit:
> >> >> >
> >> >> >
> >> >> > Please keep messages on-topic and check the ITK FAQ at:
> >> >> >
> >> >> >
> >> >> > Follow this link to subscribe/unsubscribe:
> >> >> >
> >> >> >
> >> >
> >
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100903/3f86bd67/attachment.htm>

More information about the Insight-developers mailing list