[Insight-developers] Gerrit Wish list

[Matthew McCormick (thewtex)]

As a suggestion, if looking for new or extending viewers, I think cgit
is preferable to gitweb.
http://hjemli.net/git/cgit/

Matt

On Wed, Oct 27, 2010 at 7:28 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> That's great. It makes more sense to delegate this to a viewer.
> Let me know which one you and Marcus pick and when we can change it.
>
> Thanks,
>
> Bill
>
> On Wed, Oct 27, 2010 at 3:53 PM, David Cole <david.cole at kitware.com> wrote:
>> I think this type of functionality belongs in git web based viewer code
>> (that recognizes gerritt change ids, and can be configured to point to a
>> gerrit instance) rather than in the commit objects themselves.
>>
>> That's a whole additional tool now (several, actually), to consider
>> contributing changes to.
>>
>> On Wed, Oct 27, 2010 at 3:41 PM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>>>
>>> Marcus,
>>>
>>> It would be nice if somehow the commit message could contain a link to
>>> the gerrit patch. Then when browsing the git repository, you could
>>> navigate to the discussion. I don't know how this could be done. Maybe
>>> in the gerrit hook. Maybe there is not enough information to do it?
>>>
>>> I just tried this query:
>>>
>>> http://review.source.kitware.com/#q,change:Ifc32e3a2dc5feb5a0309f8fa0a0e8d66bb87e3cf+project:ITK+branch:master,n,z
>>>
>>> and it worked. looks like there is enough info. The downside is that
>>> if the review site goes away or changes it's url, the link will be
>>> wrong.
>>>
>>> Thoughts,
>>>
>>> Bill
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>