[Insight-developers] Gerrit topics for one-line fixes?

[Bradley Lowekamp]

Hello Kent,

I see no one answered this yet so I'll give you my thought for what it's worth.


On Oct 21, 2010, at 1:08 PM, kent williams wrote:

> Hans has been working through the ITK Bug tracker and assigning me a bunch
> of low-hanging-fruit bugs -- the first of which --
> 
> http://public.kitware.com/Bug/view.php?id=3419
> 
> Is a matter of changing one word in a string literal.

This one seem very trivial, and it's in a literal so I don't see what could go wrong with it.

> 
> Is this the sort of thing that could be pushed to master without its own
> Gerrit topic and review?

But with that being said, I have made dumb mistakes on this kind of trivial thing before. For simple, one line changes I would just be tempted to dump it into Gerrit for 24-hours, and then push it after that period even with out a review. With the thought that some one may have glanced at it, but not commented. This may help reduce the chance of accidentally breaking the nightly build which happens on occasion, or other mistakes of less consequence.

> 
> Would it be better to have one omnibus patch pushed to Gerrit for several of
> these simple bugs?

I would strongly object to placing all of these bug into a single commit. One topic branch would be OK, but an unfocused commit I think is bad.

Additionally I am still maintaining the first line of the commit as BUG:##### and/or the topic name too, but I am old fashion. I think it really helps linking the Mantis to the commit or topic if more information is needed.

It sounds like a great idea to knock out these bugs. Thanks!

Brad

> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers