[Insight-developers] VS Linker errors related to QuadEdgeMesh move

[Gelas, Arnaud Joel Florent]

Bill,

You're right the first mistake was not to use gerrit!!!

The error in the compilation was due to a missing include (itkMacro.h) and of course for windows the confusion ITKCommon_EXPORT / ITK_EXPORT.
I have now some problems to publish the change, you can find attach a patch to fix my errors.

Can anyone apply this patch and push it on the repository (I won't be able to make it before 1 hour or so), please?

Thanks a lot,

Best,
Arnaud 

________________________________________
From: Bill Lorensen [bill.lorensen at gmail.com]
Sent: Thursday, October 14, 2010 11:13 PM
To: Gelas, Arnaud Joel Florent
Cc: Insight Developers
Subject: Re: [Insight-developers] VS Linker errors related to QuadEdgeMesh move

Arnaud,

You should have added
ITKCommon_EXPORT to the .h file of any .cxx files.

ITK_EXPORT to the .h of any .txx files.

You really should have done this through gerrit and someone would have
caught it,

Bill

On Thu, Oct 14, 2010 at 9:48 PM, Gelas, Arnaud Joel Florent
<Arnaud_Gelas at hms.harvard.edu> wrote:
> My apologizes for tonight's red dashboard...
>
> I am now fixing my mistake, and it should be green again on continuous build tomorrow morning...
>
> Arnaud
>
> ________________________________________
> From: insight-developers-bounces at itk.org [insight-developers-bounces at itk.org] On Behalf Of Arnaud GELAS [arnaud_gelas at hms.harvard.edu]
> Sent: Thursday, October 14, 2010 6:21 PM
> To: Bill Lorensen
> Cc: Insight Developers
> Subject: Re: [Insight-developers] VS Linker errors related to QuadEdgeMesh move
>
>  Bill,
>
> As you pointed it, I have added ITK_EXPORT to class itkQuadEdge*
> declaration, and just pushed.
>
> Thanks!
> Arnaud
>
> On 10/14/2010 01:15 PM, Bill Lorensen wrote:
>> The  VS dashboards that build shared are reporting linker errors...
>> For example,
>> http://www.cdash.org/CDash/viewBuildError.php?buildid=748576
>>
>> I suspect the need for class ITKCommon_EXPORT in the class declaration
>> of itkQuadEdge.
>>
>> Bill
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-COMP-add-missing-include-fix-dll-import-export-name-.patch
Type: application/octet-stream
Size: 1328 bytes
Desc: 0001-COMP-add-missing-include-fix-dll-import-export-name-.patch
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101015/198fd1ec/attachment.obj>