[Insight-developers] Questioning more changes by uncrustify

[Bradley Lowekamp]

I was just looking at the following change by uncrustify:

http://itk.org/gitweb?p=ITK.git;a=blobdiff;f=Code/Common/itkNumericTraitsRGBAPixel.h;h=850dd2ad72720ece6448b3b12b1a7362056f164e;hp=8284f4348510805c56b25d9b6be43bc3a930903d;hb=HEAD;hpb=9d1dfa69d05df2d582529b401f742f946f348c0e

I would like to draw your attention to the following change:
 /** Component wise defined elements
    *
    * \note minimum value for floating pointer types is defined as
    * minimum positive normalize value.
    */
-  static const Self max( const Self & )
-    {
-      return Self( NumericTraits< T >::max() );
-    }
-  static const Self min( const Self & )
-    {
-      return Self( NumericTraits< T >::min() );
-    }
+  static const Self max(const Self &)
+  {
+    return Self( NumericTraits< T >::max() );
+  }
+
+  static const Self min(const Self &)
+  {
+    return Self( NumericTraits< T >::min() );
+  }
+

Uncrustify added spacing between these inlined function definitions. While this does not result in changing the meaning in C++, it does change the doxygen! The comment will not be associated with the other methods any more. And "pointer" should likely be just "point", which it most likely my fault. 

I just wanted to point out this additional uncrustify issue. But as we don't seem to regularly run doxygen, perhaps it not a big deal :)

Brad

========================================================
Bradley Lowekamp  
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine 
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101006/85fd5f5a/attachment.htm>