[Insight-developers] Utilities/hooks.sh

[Matthew McCormick (thewtex)]

On Tue, Oct 5, 2010 at 5:11 PM, Brad King <brad.king at kitware.com> wrote:

> On 10/05/2010 04:01 PM, Bill Lorensen wrote:
> > Actually, there were six reviewers. You were the only one to review
> > it. Looks like a process breakdown.
>
> At first I was the only reviewer.  After I approved it then someone
> (Matt?) requested additional reviewers.  Gerrit does not prevent new
> reviews once one person has approved.  None of the new reviewers
> performed reviews for a week.  When it came up on the phone call today
> that there were so many open changes in Gerrit I decided to merge it.
>
>
I appended more reviewers in the hopes of giving the issue more attention.
 Of course, anyone is welcome to add themselves to the reviewer list or
remove themselves if the are not interested/do not have time for it.  I do
not want to be a burden, so it would be nice if patches that receive the
prescribed amount of favorable reviews get merged without requiring extra
developer effort.



> > I think it is good to have a script to do the setup perhaps it could
> > echo more info about what it is doing..
> >
> > I just ran it and got this message:
> > cd ../ITKPersonal
> > [ITKPersonal(master)] Utilities/hooks.sh
> > fatal: Couldn't find remote ref remotes/origin/hooks
> > fatal: The remote end hung up unexpectedly
> >
> > Did you run it?
>
> Did you clone from itk.org/ITK.git or some other (GitHub?) repo?
> If the origin does not have the hooks branch then you can get a
> message like that.  However, the hook contains a check for the
> existence of the hooks branch before using it.
>
> Matt, any idea what goes wrong with the for-each-ref check?
>
> It looks pretty good, but in Patch Set 3 I improved the regex.
http://review.source.kitware.com/#change,103
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101005/369bdfbd/attachment.htm>