[Insight-developers] Gerrit : Abandoning changes.

[Hans Johnson]

Keep in mind that it is easy to move items from abandoned back to open.
They are not thrown away or lost.  "Abandoned" is a bad name, and I wish
there was named "Temporarily on Hold" place for these items.

We currently have more than 1 page worth of open gerrit tickets.  Many of
which are more than 2 weeks old.  It is my experience that gerrit patches
more than 2 weeks old are pretty much ignored, and they start to become
"Noise" that must be sifted through as we try to move items that are ready
for review through the system.

Ideally there would be one more area in Gerrit for "second-tier" patchsets.
First tier patch sets are ones that are actively being finalized, and every
effort should be put into getting them into the master branch ASAP.  The
second-tier patches are ones that were initially rejected, and may need a
couple of months pondering to figure out the correct way to resolve, or one
of many other reasons that they may not re ready for first tier-treatment at
the moment.

I'm currently having a difficult time with determining what patches in the
open gerrit list are "straw-man proposals for comment" and which ones are
ready to be merged into master.

Hans



On 11/23/10 6:23 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:

> 7 days is a bit quick. Maybe something like 30 days...
> 
> On Tue, Nov 23, 2010 at 5:50 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> 
>> As it was requested at the tcon,
>> 
>> Marcus has configured a process in Gerrit  for allowing
>> a group of ITKv4 developers to forcefully abandon patches
>> authored by other developers.
>> 
>> This was done by creating a Gerrit group called:  ITK-admin
>> 
>>      http://review.source.kitware.com/#admin,group,14
>> 
>> current members in this group are:
>> 
>> * Bill Lorensen
>> * Brad Lowekamp
>> * Hans Johnson
>> * Marcus Hanwell
>> * Luis Ibanez
>> 
>> 
>> If any of you want to be added to this group,
>> please let us know.
>> 
>> 
>> Hans suggestion at the tcon is that any Gerrit patch
>> that goes inactive for more than 7 days should be
>> abandoned.
>> 
>> 
>> 
>>        Luis
>> 
>> 
>> 
>> _______________________________________________
>> Powered by www.kitware.com
>> 
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>> 
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>> 
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>> 
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>> 
>>