[Insight-developers] Get rid of ITK_OnDiskStorageTypeName?

[Luis Ibanez]

Kent,

No Objection to the removal of this attribute,
from this corner.

     Luis


--------------------------------------------------------
On Fri, Nov 12, 2010 at 11:31 AM, kent williams <norman-k-williams at uiowa.edu
> wrote:

> In removing the dependence on dynamic_cast and typeid in the Code/IO
> classes, I happened upon some code that needs to go away, where the
> attribute ITK_OnDiskStorageTypeName is set during the ImageIOBase::Read
> method.
>
> Here's why I think it needs to go away:
>
> 1. In general, what scalar type was used on-disk is irrelevant once you've
> read the image into an itk::Image of your specified type.  That's rather
> the
> whole point of ImageIO
>
> If you really need to find that out, you can instantiate the appropriate
> ImageIO class and 'sniff' the file without reading it.
>
> 2. The only classes I actually put this code in were the ones I wrote in
> 2003, and most ImageIO classes don't bother setting that MetaDataDictionary
> attribute.  So I doubt anyone is depending on it being there, precisely
> because you CAN'T depend on it being there.
>
> 3. It's the last place where typeid is used in ImageIO.
>
> Anyone object?
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101120/69107350/attachment-0001.htm>