[Insight-developers] adding authors to Gerrit reviewers

[Wes Turner]

I hesitate for suggesting this since it could end up sounding like a request
for more work, but familiarity with the previous version is not necessarily
the only issue that impacts a code review.  My code contributions to ITK are
pretty small, but I have used ITK for a number of years and have even helped
guide new hires and interns in using and contributing to ITK.  So far I've
completed 3 code reviews and found 3 issues ...

- Wes

On Wed, Nov 17, 2010 at 10:49 AM, Marcus D. Hanwell <
marcus.hanwell at kitware.com> wrote:

> Bill,
>
> I agree, I think it is absolutely great to generate suggested
> reviewers but it is also quite error prone. It is a great script that
> is certainly quite useful, but probably needs some degree of human
> intervention (or those that make sweeping changes accept a lot of
> false positives).
>
> Marcus
>
> On Sun, Nov 14, 2010 at 1:58 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> > Luis,
> >
> > For example, you and I have probably touched every file in itk. Do you
> > want to be a reviewer on every gerrit topic? Brad L. and Hans also.
> >
> > Bill
> >
> > On Sun, Nov 14, 2010 at 1:38 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> >> I don't think it should be a hook. It adds a lot of reviewers (I
> >> think) and reviewers can be overwhelmed with these auto generated
> >> reviewer lists.
> >>
> >> On Sun, Nov 14, 2010 at 1:12 PM, Luis Ibanez <luis.ibanez at kitware.com>
> wrote:
> >>>
> >>> Matt,
> >>>
> >>> This looks great !
> >>>
> >>> Marcus:
> >>>
> >>> Do you see any reason for not adding this scripts
> >>> to the directory:
> >>>
> >>>      ITK/Utilities/DevelopmentSetupScripts
> >>>
> >>>
> >>> or even to make this an automatic hook ?
> >>>
> >>>
> >>>    Thanks
> >>>
> >>>
> >>>         Luis
> >>>
> >>>
> >>>
> >>> --------------------------------------------------------------
> >>> On Fri, Nov 12, 2010 at 8:58 AM, Matthew McCormick (thewtex)
> >>> <matt at mmmccormick.com> wrote:
> >>>>
> >>>> Hi,
> >>>>
> >>>> I scraped together a simple script to automate selection and
> >>>> submission of Gerrit reviewers.  Here is a link in case anyone else
> >>>> may find it useful:
> >>>> https://gist.github.com/674093
> >>>>
> >>>> Candidates are nominated from former authors of the edited files.
> >>>> People probably want to know when I am breaking ... I mean, fixing ;-)
> >>>> .. their files, and they are probably the most knowledgeable
> >>>> individuals of the issues at hand.  It saves having to pick out
> >>>> reviewers manually and the need to re-enter reviewers for every commit
> >>>> on a long topic branch.
> >>>>
> >>>> It has rudimentary user interactivity, but more could be done with it.
> >>>>  I don't have time to rigorously fix it up, but if someone is
> >>>> interested, go for it.
> >>>>
> >>>> To use it, run it instead of 'git gerrit-push' on the initial push to
> >>>> Gerrit.
> >>>>
> >>>> Matt
> >>>> _______________________________________________
> >>>> Powered by www.kitware.com
> >>>>
> >>>> Visit other Kitware open-source projects at
> >>>> http://www.kitware.com/opensource/opensource.html
> >>>>
> >>>> Kitware offers ITK Training Courses, for more information visit:
> >>>> http://kitware.com/products/protraining.html
> >>>>
> >>>> Please keep messages on-topic and check the ITK FAQ at:
> >>>> http://www.itk.org/Wiki/ITK_FAQ
> >>>>
> >>>> Follow this link to subscribe/unsubscribe:
> >>>> http://www.itk.org/mailman/listinfo/insight-developers
> >>>
> >>>
> >>> _______________________________________________
> >>> Powered by www.kitware.com
> >>>
> >>> Visit other Kitware open-source projects at
> >>> http://www.kitware.com/opensource/opensource.html
> >>>
> >>> Kitware offers ITK Training Courses, for more information visit:
> >>> http://kitware.com/products/protraining.html
> >>>
> >>> Please keep messages on-topic and check the ITK FAQ at:
> >>> http://www.itk.org/Wiki/ITK_FAQ
> >>>
> >>> Follow this link to subscribe/unsubscribe:
> >>> http://www.itk.org/mailman/listinfo/insight-developers
> >>>
> >>>
> >>
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 
Wesley D. Turner, Ph.D.
Kitware, Inc.
Technical Leader
28 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4920
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101117/9dbb610a/attachment-0001.htm>