[Insight-developers] Failing Tests after Checkins

kent williams norman-k-williams at uiowa.edu
Tue Nov 16 11:11:10 EST 2010 

The problem is weird, because it only fails (for me) when run under
valgrind.  I think it might have to do with valgrind initalizing memory
differently.

But as near as I can figure, the problem really comes in the constructor for
MovingHistogramImageFilterBase:

template< class TInputImage, class TOutputImage, class TKernel >
MovingHistogramImageFilterBase< TInputImage, TOutputImage, TKernel >
::MovingHistogramImageFilterBase()
{
  m_PixelsPerTranslation = 0;
  // call again SetKernel in that class, to have the offsets computed for
  // the default kernel. An AnalyzeKernel() method as in the binary
  // morphology class may be a better way to go.
  this->SetKernel( this->GetKernel() );
}

The m_Kernel member of itkKernelImageFilter needs proper initialization in
its constructor, and when I chase the hierachy up from the Kernel type
(itk::BinaryBallStructuringElement) I get to itkNeighborhood, which
allocates an array m_DataBuffer but never initializes it.


On 11/16/10 8:44 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:

> Yes, but the intermittent failures started occurring after Kent's
> recent check ins. Be sure to look at his also.
> 
> Bill
> 
> 2010/11/16 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>> 
>> Hi,
>> 
>> This is certainly caused by my recent cleaning in the consolidated
>> morphology contribution.
>> 
>> I'll have a look.
>> 
>> Gaëtan
>> 
>> 
>> Le 16 nov. 10 à 14:20, Bill Lorensen a écrit :
>> 
>>> Kent,
>>> 
>>> This valgrind report may help:
>>> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=955423
>>> 
>>> In fact many morphology tests have valgrind errors:
>>> http://www.cdash.org/CDash/viewDynamicAnalysis.php?buildid=776485
>>> 
>>> These are all recent.
>>> 
>>> Bill
>>> 
>>> On Mon, Nov 15, 2010 at 10:30 AM, Bradley Lowekamp
>>> <blowekamp at mail.nih.gov> wrote:
>>>> 
>>>> Kent,
>>>> I think this failing test may be the result of your removal of typeid:
>>>> 
>>>> http://www.cdash.org/CDash/testSummary.php?project=2&name=itkMathematicalMo
>>>> rphologyImageFilterTest&date=2010-11-15
>>>> This is when things started:
>>>> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=772432
>>>> It appears some of the morphology tests randomly fail, perhaps there is
>>>> an
>>>> un-initialzied variable or something?
>>>> Brad
>>>> On Nov 13, 2010, at 9:09 PM, Bill Lorensen wrote:
>>>> 
>>>> Let's look in the morning.
>>>> 
>>>> On Sat, Nov 13, 2010 at 6:27 PM, Hans Johnson <hans-johnson at uiowa.edu>
>>>> wrote:
>>>> 
>>>> When I ordered the testing according to checkout time.  When I look now,
>>>> it
>>>> 
>>>> appears to have many fewer failures.
>>>> 
>>>> Earlier today when I looked at this, the failures were grouped into
>>>> 
>>>> failing/passing cases based on "Build Time" and not on any particular
>>>> 
>>>> platform.  That was why I hypothesized the submodule problem.
>>>> 
>>>> It appears that many of those machines have re-submitted new nightly
>>>> builds
>>>> 
>>>> since then, and those test do not seem to be failing any more.
>>>> 
>>>> Hans
>>>> 
>>>> 
>>>> 
>>>> On 11/13/10 3:53 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>>> 
>>>> There are not failing on every platform. Look at the dashboard and
>>>> 
>>>> look for +2's or +1's in the failing tests.
>>>> 
>>>> On Sat, Nov 13, 2010 at 11:47 AM, Hans Johnson <hans-johnson at uiowa.edu>
>>>> wrote:
>>>> 
>>>> I'm not getting those failures.  I wonder if it happens to be a problem
>>>> with
>>>> 
>>>> the Ctest not updating the sub-modules.
>>>> 
>>>> Hans
>>>> 
>>>> 
>>>> On 11/13/10 7:35 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>>> 
>>>> Kent,
>>>> 
>>>> A number of tests are failing after your recent checkins:
>>>> 
>>>> http://www.cdash.org/CDash/viewUpdate.php?buildid=772432
>>>> 
>>>> First detected in this continuous:
>>>> 
>>>> http://www.cdash.org/CDash/viewUpdate.php?buildid=772432
>>>> 
>>>> Bill
>>>> 
>>>> _______________________________________________
>>>> 
>>>> Powered by www.kitware.com
>>>> 
>>>> Visit other Kitware open-source projects at
>>>> 
>>>> http://www.kitware.com/opensource/opensource.html
>>>> 
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> 
>>>> http://kitware.com/products/protraining.html
>>>> 
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> 
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>> 
>>>> Follow this link to subscribe/unsubscribe:
>>>> 
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>> 
>>>> --
>>>> 
>>>> Hans J. Johnson, Ph.D.
>>>> 
>>>> Assistant Professor
>>>> 
>>>> 200 Hawkins Drive
>>>> 
>>>> T205 BT, The University of Iowa
>>>> 
>>>> Iowa City, IA 52242
>>>> 
>>>> hans-johnson at uiowa.edu
>>>> 
>>>> PHONE: 319 353 8587
>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Hans J. Johnson, Ph.D.
>>>> 
>>>> Assistant Professor
>>>> 
>>>> 200 Hawkins Drive
>>>> 
>>>> T205 BT, The University of Iowa
>>>> 
>>>> Iowa City, IA 52242
>>>> 
>>>> hans-johnson at uiowa.edu
>>>> 
>>>> PHONE: 319 353 8587
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>> 
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>> 
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.html
>>>> 
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>> 
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>> 
>>>> ========================================================
>>>> 
>>>> Bradley Lowekamp
>>>> 
>>>> Lockheed Martin Contractor for
>>>> 
>>>> Office of High Performance Computing and Communications
>>>> 
>>>> National Library of Medicine
>>>> 
>>>> blowekamp at mail.nih.gov
>>>> 
>>>> 
>>> _______________________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>> 
>> --
>> Gaëtan Lehmann
>> Biologie du Développement et de la Reproduction
>> INRA de Jouy-en-Josas (France)
>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> http://voxel.jouy.inra.fr  http://www.itk.org
>> http://www.mandriva.org  http://www.bepo.fr
>> 
>>

More information about the Insight-developers mailing list