[Insight-developers] Welcome to ITKv4

[M.Staring at lumc.nl]

Hi Bill, thanks for the info.

Ah. So, only a few people can update the master copy.

Should I still have used gerrit ?
Should I leave it to Brad King to take this issue from here?

Marius

-----Original Message-----
From: Bill Lorensen [mailto:bill.lorensen at gmail.com] 
Sent: dinsdag 9 november 2010 14:09
To: Staring, M. (LKEB)
Cc: marcus.hanwell at kitware.com; luis.ibanez at kitware.com; daviddoria at gmail.com; brad.davis at kitware.com; Insight Developers; Brad King
Subject: Re: Welcome to ITKv4

I believe that kwsys cannot be updated through the ITK repository.
This is also true of Utilities/MetaIO. Since kwsys is used by a number of toolkits, each toolkit is updated by kwrobot when the "master" copy is updated. This is why I suggested that you add brad king to the reviewer list. This is not just an ITKv4 issue. It has been this way for quite a while.

Bill

On Tue, Nov 9, 2010 at 4:56 AM,  <M.Staring at lumc.nl> wrote:
> After Hans suggesting to push and watch the dashboard closely
>
> http://review.source.kitware.com/#change,277
>
> I decided to push, so I did:
>
> $ git stage-push
>
> But it was rejected saying that only kwrobot may publish to kwsys:
>
> From http://itk.org//stage/ITK
>   794545f..e32869e  master     -> stage/master
> ----------------------------------------------------------------------
> commit 7fbaf2c6 not allowed: only kwrobot at kitware.com may publish 
> ('Utilities/kwsys/', 'Utilities/MetaIO/')
> ----------------------------------------------------------------------
> error: hook declined to update refs/heads/KWSysSystemInformation To 
> git at itk.org:stage/ITK.git
>  ! [remote rejected] HEAD -> KWSysSystemInformation (hook declined)
> error: failed to push some refs to 'git at itk.org:stage/ITK.git'
>
> What should I do next?
>
> Marius
>
>
> -----Original Message-----
> From: Marcus D. Hanwell [mailto:marcus.hanwell at kitware.com]
> Sent: maandag 1 november 2010 15:49
> To: Luis Ibanez
> Cc: Staring, M. (LKEB); daviddoria at gmail.com; bill.lorensen at gmail.com; 
> brad.davis at kitware.com
> Subject: Re: Welcome to ITKv4
>
> On Mon, Nov 1, 2010 at 9:56 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>
>> On Mon, Nov 1, 2010 at 6:38 AM, <M.Staring at lumc.nl> wrote:
>>>
>>> Just want to report my progress with git/gerrit and ask questions 
>>> about it. I hope it is useful for you guys.
>>>
>>> Ok, now I was able to push to gerrit. When looking at
>>>
>>> http://review.source.kitware.com/#q,status%3Aopen+project%3AITK,n,z
>>>
>>> I see two entries with me  as the owner with the same id. The top 
>>> one
>>> http://review.source.kitware.com/#change,277
>>> is the real one, the second one
>
>>> http://review.source.kitware.com/#change,276
>>> has nothing to do with code I changed.
>>> Did I do something wrong ?
>>
>> mm,
>> This one
>> http://review.source.kitware.com/#change,276
>>
>> is indeed strange.
>>
>> Maybe Marcus can help us here...
>>
> That is indeed very odd, something strange may have happened locally.
> That commit has a different hash to the one that was merged, and is a reason I was asking people to stop rebasing. Also, both of your commits have the same Change-Id in Gerrit. Are you inserting them yourself?
>
> They should be auto-generated using the Git hook, and I am not sure why Gerrit accepted two changes with the same ID. Did you copy and paste the Change-Id line in, or was it generated by the hooks? There may be a problem with the hook if so, and it would be good to know what operating system, version of Git etc you are using.
>
> Marcus
>