[Insight-developers] Need to add images for new tests to Data -- how to do that in a Gerrit topic?

[Gaëtan Lehmann]

This method looks interesting for the large images.
IMO, it doesn't look that interesting for the small test images we are  
used to have in Testing/Data, compared to a direct inclusion in the  
ITK repository.

The procedure to add a new image on midas looks quite complex also -  
nothing close to the "cvs add" we had before ITK 4 and git.

Do we really need a new layer of complexity like this one? I don't  
think so.
Things should be kept simple when possible.

Regards,

Gaëtan


Le 4 nov. 10 à 21:04, Bill Lorensen a écrit :

> I hope you have some discussion about this in Iowa. I assume it is a
> proposal and not a mandate.
>
> I hope that Baselines will remain (go back) in the ITK repository (not
> a submodule). They currently take 17 megs.
>
> Test data is another issue. If there is a solution it must allow
> testing without an internet connection.
>
> Bill
>
> On Thu, Nov 4, 2010 at 2:45 PM, Luis Ibanez  
> <luis.ibanez at kitware.com> wrote:
>>
>> Gaetan,
>>
>> We will be demonstrating the use of MIDAS for
>> hosting ITK Testing Data at the Iowa meeting.
>>
>> The essential changes can be seen in the
>> following Gerrit patch:
>>
>>    http://review.source.kitware.com/#change,301
>>
>>
>> Instructions are available at:
>>
>>   http://www.itk.org/Wiki/ITK_Release_4/Testing_Data
>>
>>
>> ---
>>
>> Essentially:
>>
>> * For every data file required for testing we will put its
>>   identification md5 checksum in a file, in the directory
>>   ITK/Testing/MIDAS_Keys
>>
>> * For every ITK tests, in the CMakeLists.txt files, we
>>    will replace:
>>
>>    add_test( test007 executable
>>       input.png
>>       output.png
>>       )
>>
>>
>> with
>>
>>
>>    midas_add_test(test007 executable
>>        MIDAS{input.png.md5}
>>        output.png
>>        )
>>
>>
>> The CMake script in
>>
>>        ITK/CMake/MIDAS.cmake
>>
>> will take care of the rest.
>>
>>
>> Images will be downloaded at the moment
>> of running "ctest".
>>
>> ---
>>
>> When a new image needs to be added to the
>> test suite, you will first upload the image to
>> the ITK Testing collection in MIDAS:
>>
>> http://midas.kitware.com/community/view/7
>>
>> and then will add its corresponding MD5 keyfile
>> to the directory
>>
>>          ITK/Testing/MIDAS_Keys
>>
>> Then you will edit the add_test command in the
>> CMakeLists.txt file,
>>
>> and
>>
>> Finally,
>> you will submit your Git patch to Gerrit.
>>
>>
>>
>> Any reviewer who download the patch, will
>> be able to build ITK, and at the moment of
>> running the tests, CMake will download the
>> necessary images from MIDAS.
>>
>>
>>
>> ---------------------------
>>
>> Please give it a try at the Gerrit patch and
>> let us know what you think.
>>
>>
>>      Thanks
>>
>>
>>            Luis
>>
>>
>> -----------------------------------------------------------
>> 2010/11/4 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>
>>>
>>

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101105/7437c469/attachment.pgp>