[Insight-developers] Need to add images for new tests to Data -- how to do that in a Gerrit topic?

Thu Nov 4 13:22:52 EDT 2010

Hey all,

Patrick forwarded me this message.  Xiaoxiao is currently working on a demo
of using MIDAS to host ITK testing data, which will work around the issue of
the large data submodule.  We're planning to demo this on Monday at the ITK
meeting in Iowa.

Test data is hosted on a MIDAS server, and is addressed by the hash of its
contents, which guarantees its integrity.  The data is downloaded at test
time rather than source-checkout time, so someone who initially checks out
the repository won't have to worry about whether they also want to clone the
testing data submodule.

-Zach

On Thu, Nov 4, 2010 at 1:04 PM, Zach Mullen <zach.mullen at kitware.com> wrote:

>
>
> On Thu, Nov 4, 2010 at 1:03 PM, Patrick Reynolds <
> patrick.reynolds at kitware.com> wrote:
>
>> Are you on this list?
>>
>> Thanks,
>> Patrick Reynolds
>> R & D Engineer
>> Kitware, Inc.
>> 919 969 6990 x303
>>
>> Negative.
>
>>
>>
>>
>>
>> ---------- Forwarded message ----------
>> From: Matthew McCormick (thewtex) <matt at mmmccormick.com>
>> Date: Thu, Nov 4, 2010 at 12:11 PM
>> Subject: Re: [Insight-developers] Need to add images for new tests to
>> Data -- how to do that in a Gerrit topic?
>> To: Bill Lorensen <bill.lorensen at gmail.com>
>> Cc: Daniel Blezek <Blezek.Daniel at mayo.edu>, Hans Johnson
>> <hans-johnson at uiowa.edu>, ITK <insight-developers at itk.org>, Luis
>> Ibanez <luis.ibanez at kitware.com>, kent williams
>> <norman-k-williams at uiowa.edu>
>>
>>
>> Git submodules are a fantastic thing.  A git submodule is simply a
>> pointer to the
>>
>> 1. URL of the sub-repository
>> 2. The path in the tree where it is located
>> 3. The commit that the submodule is at for the current commit.
>>
>> The first two are simply kept in the .gitmodules file of the
>> repository.  The third has great integration with git, so it is
>> efficient to work with.
>>
>> It means you can do the following
>>
>>  git checkout -b examine_an_old_version <some old commit hash>
>>  git submodule update
>>
>> And all the submodules will be at the state they were at in the old
>> commit.
>>
>> Many of the projects in the Utilities/ direction should be submodules.
>>  With a submodule,
>>
>> 1.  The commit history of a separate logical unit is kept separate
>> 2.  It is easier to bring in changes from upstream.
>> 3.  It is easier to push changes upstream.
>> 4.  Copied code is kept to a minimum.
>>
>> For an example of a Kitware project that does a nice job of using
>> submodules, see Paraview.
>>
>> However, having Testing/Data as a submodule is a workaround for a
>> deficiency in distributed version control systems.  I, too, once had a
>> Testing/Data repository that I tried to keep all the images for my
>> personal projects.  But it quickly became too big.  It took too long
>> to download and it took up too much disk space.  For a project like
>> ITK, bringing the Testing/Data into the main repository is not
>> feasible.  I think the MIDAS solution sounds interesting, and it could
>> be of use to the general git community.  We need a way to grab a
>> repository without downloading the entire Git history.  Yet, version
>> correspondence should still be intact.
>>
>> Regards,
>> Matt
>>
>> On Thu, Nov 4, 2010 at 9:35 AM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>> > Please keep the process as simple as possible. We need to encourage
>> testing.
>> >
>> > My preference would be to move the Testing baselines into the main
>> > repository, just like it was before.  Adding a baseline should be as
>> > painless as possible. The Testing data can reside somewhere else, but,
>> > as Kent said, it should be downloadable all at once to allow testing
>> > without an internet connection.
>> >
>> > I think the current setup is too complicated. Actually, I don't
>> understand it.
>> >
>> > On Thu, Nov 4, 2010 at 10:18 AM, kent williams
>> > <norman-k-williams at uiowa.edu> wrote:
>> >> I don’t object to using one of those remote repository methods to store
>> test
>> >> data, with these concerns:
>> >>
>> >> The complexity of the process needs to be managed.  If it means I have
>> learn
>> >> a new API and write an extra hundred lines of code just to pull an
>> image
>> >> down for testing, that’s breaking the current process.
>> >> There should be a way to pull down the testing data corpus as a whole.
>> You
>> >> should be able to run CTest without an Internet connection.
>> >> I’m not sure anyone wants to go back and re-write every existing
>> regression
>> >> test.  Even if it only takes 10 minutes a test that would be nearly 7
>> weeks
>> >> of full time work.
>> >>
>> >> Some of these concerns could be addressed with CMake --
>> >>
>> >> Have a CMake Macro that can grab a file based on URL or whatever, and
>> store
>> >> it in the Data directory. Maybe roll this into add_test() -- something
>> like
>> >> add_test(<current params> REQUIRED_DATA_FILES <list of URLs or
>> whatever>)
>> >> Have a top level CMake option that defaults false —
>> >> FETCH_AND_CACHE_TEST_DATA
>> >>
>> >>
>> >>
>> >> On 11/4/10 7:58 AM, "Hans Johnson" <hans-johnson at uiowa.edu> wrote:
>> >>
>> >> We should revisit the earlier discussed topic of removing data from the
>> SCM
>> >> repository all together, and make all data accessible through a public
>> >> repository outside the ITK development tree (MIDAS, http, XNAT,
>> something
>> >> else, all of these....).
>> >>
>> >> The data should be dynamically downloaded during the running of the
>> tests
>> >> and cached locally when needed.
>> >>
>> >> Hans
>> >>
>> >> _______________________________________________
>> >> Powered by www.kitware.com
>> >>
>> >> Visit other Kitware open-source projects at
>> >> http://www.kitware.com/opensource/opensource.html
>> >>
>> >> Kitware offers ITK Training Courses, for more information visit:
>> >> http://kitware.com/products/protraining.html
>> >>
>> >> Please keep messages on-topic and check the ITK FAQ at:
>> >> http://www.itk.org/Wiki/ITK_FAQ
>> >>
>> >> Follow this link to subscribe/unsubscribe:
>> >> http://www.itk.org/mailman/listinfo/insight-developers
>> >>
>> >>
>> > _______________________________________________
>> > Powered by www.kitware.com
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Kitware offers ITK Training Courses, for more information visit:
>> > http://kitware.com/products/protraining.html
>> >
>> > Please keep messages on-topic and check the ITK FAQ at:
>> > http://www.itk.org/Wiki/ITK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://www.itk.org/mailman/listinfo/insight-developers
>> >
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101104/aaaebfac/attachment.htm>