[Insight-developers] Need to add images for new tests to Data -- how to do that in a Gerrit topic?

[Wes Turner]

Hey Marcus,

On Wed, Nov 3, 2010 at 5:18 PM, Marcus D. Hanwell <
marcus.hanwell at kitware.com> wrote:

> On Wed, Nov 3, 2010 at 4:55 PM, kent williams
> <norman-k-williams at uiowa.edu> wrote:
> > Subject line says it all.
> >
> > Have a couple of small images that I need to add to ITK/Data submodule --
> > how do I add them so that the Gerrit topic I'm pushing can access them?
> >
> You don't need to, you could add them to the repository now and they
> will not hurt anything. There is no ITK data repository in Gerrit, and
> review of the binary image files wouldn't work. Can't people generate
> these images themselves if they want to? There is some work at the
> moment to make things easier here - Luis may comment more on that.
>
>
Are you suggesting that reviewers manually generate binary images specific
to a test before performing a Gerrirt review of a new submission?  That's a
pretty big bar.  My normal mode is to get a clean "Review" directory of ITK,
download the patch, run a "ctest -D Experimental" to make sure all the tests
pass, and while the experimental is running perform a code walk through. If
I need to generate a new binary image before the tests will pass, the review
time goes way up ... and any failure would require that I determine which of
the image or the code are wrong ....

If on the other hand, you are suggesting that the images be loaded into the
data submodule and that the reviewers manually download the new images, then
that would probably be workable, although finding a way to point this out to
the reviewer while the patch is being retrieved would be a great help.

- Wes

> Marcus
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 
Wesley D. Turner, Ph.D.
Kitware, Inc.
Technical Leader
28 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4920
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101104/6b6a9737/attachment.htm>