[Insight-developers] Interpolation of complex images

[Emmanuel Christophe]

Hi Luis,

The instantiation test is now added at the end of the
itkBSplineDecompositionImageFilterTest. Such instantiation was failing
before the correction. I was not able to reproduce the full test as
the RandomImageSource also supposed a pixel type convertible to
double.

I will definitely look at the whole chain but as the corrections might
spread, after the release would be a better time.

Emmanuel


On Thu, Mar 18, 2010 at 23:30, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> Hi Emmanuel,
>
> Thanks  a lot for looking into this problem and for generating a patch.
>
> Please add a test for this functionality.
>
> The green build doesn't mean much,
> if the new functionality is not exercised yet      :-)
>
>
> Feel free to add to the existing test or to add a new test.
>
> Don't hesitate to let us know if you run into any problem.
>
> Once you have a test that exercises the new functionality
> and its build is green, then you can go ahead and commit
> the patch.
>
> BTW:
> Please be aware that we are getting closer to a release,
> so we don't want to make major changes in the repository
> at this point.
>
>
>     Thanks
>
>
>           Luis
>
>
> -----------------------------------------------------------------------------
> On Thu, Mar 18, 2010 at 6:10 AM, Emmanuel Christophe
> <emmanuel.christophe at gmail.com> wrote:
>> Hi all,
>>
>> Very little prevent the use of the spline interpolation with complex
>> images in ITK. For example, the code below does not manage to compile
>> :
>>
>>  const unsigned int Dimension=2;
>>  typedef std::complex<double> PixelType;
>>  typedef itk::Image<PixelType,Dimension> ImageType;
>>  typedef itk::BSplineDecompositionImageFilter<ImageType, ImageType> FilterType;
>>  FilterType::Pointer filter = FilterType::New();
>>
>> The assumption taken in the BSplineDecompositionImageFilter is that
>> the pixel type should be convertible to double.
>>
>> Using the patch attached, the program successfully compile and
>> interpolation of complex image is possible.
>>
>> This patch removes the assumption that the pixel type should be
>> convertible to double and separate the template for the type of the
>> pixel and the type of the spline coefficients.
>>
>> The experimental is all green, should I commit the patch?
>>
>> Should I add the code above in an existing test or create a new test for it?
>>
>> Emmanuel
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>