[Insight-developers] warnings in vnl_math

[Luis Ibanez]

Hi Arnaud,

Thanks a lot for looking at this problem.

I just added the -Wconversion flag to the Nightly
builds from "eldorado.kitware" (Release and Debug).

They use gcc 4.4.1.


Regarding Third Party libraries:

             We do warning fixes on them.


This is one of the reasons why updating third party
libraries is a pain, and why we don't make such
updates very often.  It means that we have to merge
our changes (e.g. warning fixes) with the new code
that comes from the update of the library.

Ideally our fixes should be submitted to the development
team of the third party library, to be integrated with their
code base, but this is not always easy to achieve....

For the case of VXL, this is not too difficult, since we
VXL community is quite close to us.  So, my suggestion
will be to keep track of the changes we made to VXL
related to warning fixes, and to submit them to the vxl
developers list.



       Luis


------------------------------------------------------------------------
On Thu, Mar 11, 2010 at 4:30 PM, Arnaud GELAS
<arnaud_gelas at hms.harvard.edu> wrote:
> On 03/11/2010 03:25 PM, Sean McBride wrote:
>>
>> On Thu, 11 Mar 2010 15:20:00 -0500, Arnaud GELAS said:
>>
>>
>>>
>>> I used gcc 4.4 where the warning
>>>
>>> "-Wconversion| now warns if the result of a |static_cast| to enumeral
>>> type is unspecified because the value is outside the range of the
>>> enumeral type. "
>>>
>>> So should we care about that one?
>>>
>>
>> Probably.  I just wanted to make sure you weren't wasting your time with
>> the old broken -WConversion.
>>
>>
>
> Ok, thanks!
>
> I'll set up one nightly build with -Wconversion on barracuda.megason-lab.hms
>
>
>