[Insight-developers] My first bug fix (10770)

[Casey Goodlett]

Hi Brad,

I've noticed itkIOCommonTest to fail on win64 recently as well. This happens
when ITK_LEGACY_REMOVE is configured to true.   You can observe the problem
under linux if you run it under valgrind as well.  I think it relates to
allocation of some zero length c strings in the test.  This is occurring in
a clean checkout.

Casey

2010/6/8 Bradley Lowekamp <blowekamp at mail.nih.gov>

> Hello Dženan,
>
> Congratulations on your first bug fix! It will get easier in the future
> when you know the system and tools a little better. I do hope that you are
> not including the testing as part of the "administration" costs. Testing and
> validations are very important things, as much of the time if it is not
> tested it will not be working ( or at the least it will break and no one
> would know ).
>
> Were the two tests failing before you made the changes?
>
> The itkImageFillBufferTest4.1 in known to fail on windows 64, but
> itkIOCommonTest I don't know about.
>
> Thanks,
> Brad
>
>
> On Jun 8, 2010, at 7:21 AM, Dženan Zukić wrote:
>
> Hi guys,
>
> I fixed a bug http://public.kitware.com/Bug/view.php?id=10770 (I made
> changes to local source code files). I made an experimental build
> http://www.cdash.org/CDash/buildSummary.php?buildid=629158 (release 3.18.0
> with my changes), and the are 2 tests failing (they don't seem to be related
> to my changes though). Is that a problem?
>
> Side notes:
>
>    - I downloaded and installed KWStyle version 1.0 (the only binary
>    pre-built version from the website), but cmake whines about it being too
>    old. I was too lazy to configure and build it from source, so I used the
>    online tool for checking the 2 changed files.
>    - It took me maybe 10 minutes to correct the code, but nearly a day for
>    all the administrative work around it :D
>
>
> Regards,
> Dženan
> <itkTriangleMeshToBinaryImageFilter.patch><ATT00001..txt>
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100608/722c2d8c/attachment.htm>