[Insight-developers] compilation error with system vxl

[Gelas, Arnaud Joel Florent]

Bill,

My bad, I only tested with an installed version of vxl :-/...

http://www.cdash.org/CDash/viewTest.php?onlypassed&buildid=664791
http://www.cdash.org/CDash/viewTest.php?onlypassed&buildid=664789

Thanks a lot for fixing this issue!!!

Unfortunately, I have start receiving email from the dashboard (expected failures and continuous) last night at 10 pm (my commit was about 11 am)...

Best Regards,
Arnaud

________________________________________
From: Bill Lorensen [bill.lorensen at gmail.com]
Sent: Wednesday, July 14, 2010 11:44 PM
To: Gelas, Arnaud Joel Florent
Cc: Luis Ibanez; p.vanroose at ieee.org; Peter Vanroose; vxl-users at lists.sourceforge.net; Insight Developers
Subject: Re: compilation error with system vxl

Arnaud,

I checked in a change that #if's vxl API changes depending on the vxl version. It build OK for me with the vxl that we distribute with itk. Please see if it works in the vxl version that has the non-backward compatible API change.

Also, you should have gotten emails from cdash auth the broken conitnuous builds. Did you receive them?

Bill

On Wed, Jul 14, 2010 at 8:11 PM, Bill Lorensen <bill.lorensen at gmail.com<mailto:bill.lorensen at gmail.com>> wrote:
We have lots of compiler errors now. If your fix is not compatible with our distributed vxl, then I think you should back it out.

Bill


On Wed, Jul 14, 2010 at 11:27 AM, Arnaud GELAS <arnaud_gelas at hms.harvard.edu<mailto:arnaud_gelas at hms.harvard.edu>> wrote:
Hi Luis,

I have just committed the changes.

Arnaud


On 07/13/2010 07:00 PM, Luis Ibanez wrote:
Sorry that I'm getting to this late...

Replacing mult with the * operator
sounds like a good solution.

Arnaud:

   Do you want to commit that change ?


   Thanks


        Luis


-----------------------------------------------
On Fri, Jul 2, 2010 at 8:47 AM, Bill Lorensen <bill.lorensen at gmail.com<mailto:bill.lorensen at gmail.com>> wrote:
Luis,

Should me modify the FEM code to use operator* instead of mult? A user on insight-users just reported the same issue.

Bill


On Mon, Jun 14, 2010 at 11:10 AM, Arnaud GELAS <arnaud_gelas at hms.harvard.edu<mailto:arnaud_gelas at hms.harvard.edu>> wrote:
Hi Peter,

With your change it is now compiling without any problem. Thanks for taking care of that!

Arnaud

Note: I replaced the mult by the operator *, it was perfectly working (compiling, tests were OK).



On 06/12/2010 04:52 AM, Peter Vanroose wrote:

You'll either have to update line 265 of
ITK/Code/Numerics/FEM/itkFEMLinearSystemWrapperVNL.cxx
to use the operator*() method of vnl_sparse_matrix<T>,
or make the mult() method of vnl_sparse_matrix<T> public again in your copy of vxl.

Methods mult(), add() and subtract() of vnl_sparse_matrix<T> will revert to "public" in the next vxl release, be it with a deprecation warning.


-- Peter.