[Insight-developers] Fwd: [ITK 0010205]: Recent changes to itkBayesianClassifierImageFilter.txx cause WrapITK failures

[Luis Ibanez]

Hi Hans,

Thanks a lot for pointing this out and for
adding the test case that illustrated the problem.

    http://public.kitware.com/Bug/view.php?id=10205

A fix has now been committed.

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Algorithms/itkBayesianClassifierImageFilter.txx?root=Insight&r1=1.11&r2=1.12&sortby=date
[^]

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Algorithms/itkBayesianClassifierImageFilter.h?root=Insight&r1=1.16&r2=1.17&sortby=date
[^]


The SetPriors() method was calling

               this->SetInput( 1, priors )

but the SetInput() method is defined in the superclass
(the ImageToImageFilter) as a method that takes an
InputImageType * as argument.

That was creating an incorrect entanglement between
the type of the Priors and the type of the input image.


That call has now been replaced with

   ProcessObject::SetNthInput( 1, priors)

which expects a DataObject * as argument.


---

BTW: This should also solve one of few
remaining build issues in the Dashboard,
that was illustrated in a wrapping build
in dash16.

http://www.cdash.org/CDash/viewBuildError.php?buildid=526705


     Thanks


           Luis



---------- Forwarded message ----------
From: Mantis Bug Tracker <mantis at public.kitware.com>
Date: Fri, Jan 29, 2010 at 4:42 PM
Subject: [ITK 0010205]: Recent changes to
itkBayesianClassifierImageFilter.txx cause WrapITK failures
To: luis.ibanez at kitware.com



The following issue has been ASSIGNED.
======================================================================
http://public.kitware.com/Bug/view.php?id=10205
======================================================================
Reported By:                hans-johnson
Assigned To:                karthik
======================================================================
Project:                    ITK
Issue ID:                   10205
Category:
Reproducibility:            always
Severity:                   major
Priority:                   high
Status:                     assigned
======================================================================
Date Submitted:             2010-01-29 16:42 EST
Last Modified:              2010-01-29 16:42 EST
======================================================================
Summary:                    Recent changes to
itkBayesianClassifierImageFilter.txx cause WrapITK failures
Description:
Karthik,

Your recent changes to itkBayesianClassifierImageFilter.h have exposed a
template dependancy that was causing compile time failures when using
WrapIT
K.  I've posted the compiler errors below, and committed code in the
testing directory that can be used to force the compile time error.

It looks like a type mis-match when floating point types are used.

I can make this fail in the itkBayesianClassifierImageFilterTest.cxx

#if 1
   {
   const unsigned int TestDimension = 2;
   typedef unsigned char  TestLabelType;
   typedef float          TestPosteriorType;

   //This is a failing test case!!!
   typedef float          TestPriorType;·
   typedef itk::VectorImage< double ,TestDimension >
TestInitialLabelImageType; //The element type MUST be the PriorType

   typedef itk::BayesianClassifierImageFilter<
     TestInitialLabelImageType, TestLabelType, TestPosteriorType,
TestPriorType >   TestClassifierFilterType;
   TestClassifierFilterType::Pointer
test=TestClassifierFilterType::New();
   }
#endif


Hans

======================================================================

Issue History
Date Modified    Username       Field                    Change
======================================================================
2010-01-29 16:42 hans-johnson   New Issue
2010-01-29 16:42 hans-johnson   Status                   new => assigned
2010-01-29 16:42 hans-johnson   Assigned To               => karthik
======================================================================