[Insight-developers] Dashboard Clean Up : WrapITK & TclBinaryDilateImageFilter

[Luis Ibanez]

Hi Gaetan,


      I vote for removing the test.


Unless you have a reason to think that the
test may really be revealing a bug in itk.


    Thanks


          Luis


------------------------------------------------------------
2010/1/27 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>
> We have the same test in C++, python, java and tcl.
> The problem is only with tcl.
>
> Gaëtan
>
>
> Le 27 janv. 10 à 20:22, Luis Ibanez a écrit :
>
>> Hi Gaetan,
>>
>> Thanks for looking at this test.
>>
>> Yeap,
>> it seems that I'm blaming the test failure
>> in the wrong source. Thanks for pointing
>> this out.
>>
>> ---
>>
>> It is suspicious that it works for Erosion
>> and it doesn't work for Dilation...
>>
>>
>> Do we have a C++ test that is equivalent to this one ?
>>
>>
>> I guess that, before removing the tests, we want
>> to make sure that we  are covering that same
>> functionality somewhere else.
>>
>> ...Just in case this test failure is a symptom of
>> a real problem in any of the underlying classes.
>>
>>
>>
>>     Luis
>>
>>
>>
>> ------------------------------------------------------------------
>> 2010/1/27 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>>
>>> Le 27 janv. 10 à 16:10, Luis Ibanez a écrit :
>>>
>>>> Hi Gaetan,
>>>>
>>>
>>> Hi Luis,
>>>
>>>>
>>>> Reviewing to the builds from jouy.inra.fr
>>>> the following ones have "red" issues.
>>>>
>>>> It looks like a test is attempting to display something
>>>> in the screen.  So far in ITK we do not have any tests
>>>> that require display, and therefore we have been able
>>>> to avoid requiring users to set their DISPLAY
>>>> environment variables, be logged in and set up proper
>>>> permissions when running ITK dashboard builds.
>>>>
>>>>
>>>> Could we remove the Display part of this test  ?
>>>>
>>>> and maybe replace it with a regression test ?
>>>>
>>>> (which is a more automated way of monitoring
>>>> the results of the test...).
>>>
>>>
>>> Unfortunately, this test doesn't require a X connection.
>>>
>>>
>>>  http://code.google.com/p/wrapitk/source/browse/trunk/Languages/Tcl/Tests/BinaryDilateImageFilter.tcl
>>>
>>> As you can see in the equivalent test for Erosion, the same message
>>> appears.
>>>
>>>  http://www.cdash.org/CDash/testDetails.php?test=25455818&build=524380
>>>
>>> My guess is that there is a bug in swig which makes SetKernel not be
>>> there
>>> in that class in Tcl. It's a quite long standing bug in WrapITK, but I
>>> kept
>>> it to remember about it - and maybe why I'd like to remove Tcl support.
>>>
>>> Should I remove this tests from the tests?
>>>
>>> Regards,
>>>
>>> Gaëtan
>>>
>>> --
>>> Gaëtan Lehmann
>>> Biologie du Développement et de la Reproduction
>>> INRA de Jouy-en-Josas (France)
>>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>>> http://voxel.jouy.inra.fr  http://www.itk.org
>>> http://www.mandriva.org  http://www.bepo.fr
>>>
>>>
>
> --
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.itk.org
> http://www.mandriva.org  http://www.bepo.fr
>
>