[Insight-developers] Dashboard Cleanup: RogueResearch6 : itkStatisticsAlgorithmTest : LLVM compiler

[Luis Ibanez]

Bill,

I just committed a fix.
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Review/Statistics/itkStatisticsAlgorithm.txx?root=Insight&r1=1.1&r2=1.2&sortby=date


As anticipated,
the expressions:

   sample->GetMeasurementVectorByIndex(backwardIndex)[activeDimension];

are fragile...


I replaced :

<       if (sample->GetMeasurementVectorByIndex(backwardIndex)[activeDimension]
<
<           sample->GetMeasurementVectorByIndex(backwardIndex -
1)[activeDimension])

With

>       typedef typename TSubsample::MeasurementType MeasurementType;
>       const MeasurementType value1 = sample->GetMeasurementVectorByIndex(backwardIndex)[activeDimension];
>       const MeasurementType value2 = sample->GetMeasurementVectorByIndex(backwardIndex - 1)[activeDimension];
>
>       if( value1 < value2 )


and that made the test pass in the Gcc 3.4 build.

The same fix goes for the version
of the file in Code/Numerics/Statistics:

http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Numerics/Statistics/itkStatisticsAlgorithm.txx?root=Insight&r1=1.25&r2=1.26&sortby=date


      Luis



----------------------------------------------
On Fri, Jan 22, 2010 at 4:28 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> Yeap,     :-/
>
> I'm tracking those now...
>
> Luckily (?) they are both in my desktop machines.
> (zion and redwall).
>
>
>     Luis
>
>
> ----------------------------------------------------------------
> On Fri, Jan 22, 2010 at 1:07 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> looks like some new failures cropped up:
>> http://www.cdash.org/CDash/testSummary.php?project=2&name=itkStatisticsAlgorithmTest2&date=2010-01-22
>>
>>
>> On Fri, Jan 22, 2010 at 11:28 AM, Sean McBride <sean at rogue-research.com> wrote:
>>> On 1/21/10 5:52 PM, Luis Ibanez said:
>>>
>>>>I think I have found the cause of the problem in the LLVM build.
>>>>
>>>> *SNIP*
>>>>
>>>>We will see the effect in tomorrow's
>>>>build of RogueResearch6.
>>>
>>> Looks like that fixed it!  Nice catch!
>>>
>>> --
>>> ____________________________________________________________
>>> Sean McBride, B. Eng                 sean at rogue-research.com
>>> Rogue Research                        www.rogue-research.com
>>> Mac Software Developer              Montréal, Québec, Canada
>>>
>>>
>>>
>>
>