[Insight-developers] itkObjectFactoryTest2 and CMake 2.9

[Luis Ibanez]

Bill,

Yeap,
We have to look back at how to do this right in Macs.


     Luis


----------------------------------------------
On Wed, Jan 13, 2010 at 9:58 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Guys,
>
> Six macs don't like the recent change. Looks like they are not loading
> the shared library.
>
> http://www.cdash.org/CDash/testSummary.php?project=2&name=itkObjectFactoryTest2&date=2010-01-13
>
> Bill
>
> On Wed, Jan 13, 2010 at 12:59 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> New failure here:
>> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=513466
>>
>> On Tue, Jan 12, 2010 at 6:03 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>> Fantastic!
>>>
>>> On Tue, Jan 12, 2010 at 5:39 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>>> Bill,
>>>>
>>>>
>>>> Brad just showed me how to add the right flag to
>>>> the ITK CMakeLists.txt file (the flag is for the
>>>> executable that loads the shared library).
>>>>
>>>>
>>>> It comes down to the following patch:
>>>>
>>>>
>>>> macondo [308] cvs diff
>>>> cvs diff: Diffing .
>>>> Index: CMakeLists.txt
>>>> ===================================================================
>>>> RCS file: /cvsroot/Insight/Insight/Testing/Code/Common/CMakeLists.txt,v
>>>> retrieving revision 1.249
>>>> diff -r1.249 CMakeLists.txt
>>>> 653a654
>>>>> SET_TARGET_PROPERTIES(itkCommonTests2 PROPERTIES ENABLE_EXPORTS 1)
>>>> 660c661
>>>> < ADD_LIBRARY(FactoryTestLib SHARED ${FactoryTest_Source})
>>>> ---
>>>>> ADD_LIBRARY(FactoryTestLib MODULE ${FactoryTest_Source})
>>>>
>>>>
>>>>
>>>> This should work for all versions of CMake.
>>>>
>>>>
>>>> I'm running an Experimental in "macondo.kitware"
>>>> and if it turns out green I'll commit the patch.
>>>>
>>>> This should make Kevin's builds green again...
>>>>
>>>>
>>>>     Luis
>>>>
>>>>
>>>> -----------------------------
>>>> On Tue, Jan 12, 2010 at 5:02 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>>> Sounds great. Thanks, Luis and I spent at least 3 hours apiece on this
>>>>> one in SLC.
>>>>>
>>>>> Bill
>>>>>
>>>>> On Tue, Jan 12, 2010 at 4:37 PM, Bill Hoffman <bill.hoffman at kitware.com> wrote:
>>>>>> Kevin H. Hobbs wrote:
>>>>>>>
>>>>>>> On 01/12/2010 12:48 PM, Bill Lorensen wrote:
>>>>>>>>
>>>>>>>> Luis,
>>>>>>>>
>>>>>>>> I just built cmake2.9 and configured my linux itk build with it. Sure
>>>>>>>> enough, itkObjectFactoryTest2 fails. Each hooperlab system that is
>>>>>>>> failing is using ctest2.9.
>>>>>>>>
>>>>>>>> I'm not sure what is going on here. Perhaps you can fill Bill Hoffman
>>>>>>>> in on our findings in Salt Lake. I'm going to build a cmake2.8 and see
>>>>>>>> if the problem persists.
>>>>>>>>
>>>>>>>> Bill
>>>>>>>>
>>>>>>>
>>>>>>> I'd be glad to run tests on the hooperlab machines if that would be
>>>>>>> helpful.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> We found the problem.   We are working on a fix.  The -rdynamic flag was
>>>>>> removed from CMake.   I think the dashboard can be left on CVS CMake, it
>>>>>> might fail one more night, but I will make sure it is fixed by tomorrow.
>>>>>>
>>>>>> -Bill
>>>>>>
>>>>>> --
>>>>>> Bill Hoffman
>>>>>> Kitware, Inc.
>>>>>> 28 Corporate Drive
>>>>>> Clifton Park, NY 12065
>>>>>> bill.hoffman at kitware.com
>>>>>> http://www.kitware.com
>>>>>> 518 881-4905 (Direct)
>>>>>> 518 371-3971 x105
>>>>>> Fax (518) 371-4573
>>>>>>
>>>>>
>>>>
>>>
>>
>