[Insight-developers] N4 Valgrind Errors

[Nicholas Tustison]

Thanks BIll.   That sounds like a reasonable plan.  I already pushed a patch to gerrit just to have something up to let everybody know I'm addressing the issues but let me go back and rerun KWStyle and push a second patch.  Thanks again.


On Dec 20, 2010, at 9:55 AM, Bill Lorensen wrote:

> I would suggest not using uncrustify until it and kwstyle agree.
> 
> On Mon, Dec 20, 2010 at 9:41 AM, Nicholas Tustison <ntustison at gmail.com> wrote:
>> Hi Luis,
>> Thanks again.  I was going to push all the changes to gerrit but I came
>> across the following issue regarding the coordination between uncrustify and
>> KWStyle.  So I went through and ran KWStyle on my code and made all the
>> changes so that all the KWStyle errors are taken care of.  However,
>> uncrustify went and undid some of them.  For example, it removed the blank
>> line at the end of file which I had just put in there because KWStyle
>> complained.  Additionally, the way it indents with respect to parenthesis in
>> equations can cause KWStyle length errors.  What am I doing wrong?
>> Thanks,
>> Nick
>> 
>> 
>> On Dec 20, 2010, at 8:57 AM, Luis Ibanez wrote:
>> 
>> Hi Nick,
>> 
>> This patch below will take care of most of
>> Valgrind messages about uninitialized variables.
>> 
>> 
>>      Luis
>> 
>> ---------------------------------------------
>> 
>> @@ -177,6 +177,16 @@ BSplineControlPointImageFilter<InputImage,
>> TOutputImage>
>>  ::BSplineControlPointImageFilter()
>>  {
>>    this->m_SplineOrder.Fill( 3 );
>> +  this->m_DoMultilevel = false;
>> +  this->m_MaximumNumberOfLevels = 1;
>> +  this->m_Origin.Fill(0.0);
>> +  this->m_Spacing.Fill(1.0);
>> +  this->m_Size.Fill(0);
>> +  this->m_Direction.SetIdentity();
>> +
>> +  this->m_DataPoint = NumericTraits<
>> +    typename TControlPointLattice::PixelType >::Zero;
>> +
>>    for( unsigned int i = 0; i < ImageDimension; i++ )
>>      {
>>      this->m_NumberOfControlPoints[i] = ( this->m_SplineOrder[i]+1 );
>> 
>> 
>> ------------------------------------------------------
>> On Mon, Dec 20, 2010 at 7:57 AM, Nicholas Tustison <ntustison at gmail.com>
>> wrote:
>>> 
>>> No worries.  I've been working on the KWStyle issues and will address the
>>> valgrind errors in a minute.
>>> 
>>> 
>>> On Dec 20, 2010, at 7:55 AM, Bill Lorensen wrote:
>>> 
>>>> Nick,
>>>> 
>>>> Lots of valgrind errors after N4 check ins. Looks like most are do to
>>>> initialized member data in the constructors.
>>>> http://www.cdash.org/CDash/viewDynamicAnalysis.php?buildid=805967
>>>> 
>>>> Bill
>>> 
>>> _______________________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>> 
>> 
>>