[Insight-developers] Dashboad: Looking at Valgrind

[Luis Ibanez]

Some clean up in this front....


The following patches in Gerrit should help
clean up a large chunk of the Valgrind errors:


1) http://review.source.kitware.com/#change,589
     addresses memory leaks from JPEG2000


2) http://review.source.kitware.com/#change,590
    addresses memory leaks from MetaImage.
    When the AdditionalReadFields were added,
    no provision was made to free their memory.


3) http://review.source.kitware.com/#change,592
    fix uninitialized variable in the TransformFileWriter.
    Somebody added a m_Precision variable, and
    never initialized in the constructor.


4) http://review.source.kitware.com/#change,593
    addresses memory leaks in the TransformFileReader
    and the SpatialObjectDuplicator. They are the consequence
    of the CreateInstance() method returning objects with one
    extra reference count. It is therefore needed to call
    UnRegister() after calling CreateInstance().
    The other option would have been to remove the call to
    Register() that is made inside of CreateInstance() but
    that will result in a non-backward compatible behavior.



   Luis



---------------------------------------------------
On Thu, Dec 16, 2010 at 3:10 PM, Luis Ibanez <luis.ibanez at kitware.com>wrote:

> Hi Brad,
>
> Thanks for pointing this out.
>
> Here is the summary of valgrind builds from clownfish
> since December first.:
>
>
> http://www.cdash.org/CDash/index.php?project=Insight&date=2010-12-14&filtercount=3&showfilters=1&filtercombine=and&field1=site/string&compare1=63&value1=clownfish&field2=hasdynamicanalysis/bool&compare2=0&value2=&field3=buildstarttime/date&compare3=83&value3=december%201%202010
>
> I believe that this machine is doing different sections
> of the toolkit on different days, so comparing one day
> to the next may not be representing a real increase or
> decrease in the number of issues.
>
> That said,
> you have a point in that the number of
> issues should be zero anyways               :-)
>
> ---
>
> The problem with the itkGaussianMembershipFunction.txx
> is the lack of initialization for m_Mean in the constructor.
>
> I just pushed a patch to Gerrit for this issue:
> http://review.source.kitware.com/#change,576
>
> This takes care of the following:
>
> itkGaussianMixtureModelComponentTest<http://www.cdash.org/CDash/testSummary.php?project=2&name=itkGaussianMixtureModelComponentTest&date=2010-12-16>
> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=996928
>
> itkGaussianMembershipFunctionTest<http://www.cdash.org/CDash/testSummary.php?project=2&name=itkGaussianMembershipFunctionTest&date=2010-12-16>
> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=996927
>
> itkSampleClassifierFilterTest7<http://www.cdash.org/CDash/testSummary.php?project=2&name=itkSampleClassifierFilterTest7&date=2010-12-16>
> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=996926
>
>
> Thanks
>
>
>    Luis
>
>
>
>
> ------------------------------------------------
> On Thu, Dec 16, 2010 at 10:00 AM, Bradley Lowekamp <blowekamp at mail.nih.gov
> > wrote:
>
>> Hello,
>>
>> I noticed that there a bit of an increase in the number of Valgrind
>> defects today. I believe this is likely related to the increased number of
>> statistics example that were added.
>>
>> http://www.cdash.org/CDash/viewDynamicAnalysis.php?buildid=802880
>>
>> Particularly there is likely a real issue with the
>> GaussianMembershipFunction:
>>
>> http://www.cdash.org/CDash/viewDynamicAnalysisFile.php?id=996287
>>
>> The number of Valgrind error has been increasing, for this to be a useful
>> tool, it need to be looked at and address.
>>
>> Brad
>>
>> ========================================================
>>
>> Bradley Lowekamp
>>
>> Lockheed Martin Contractor for
>>
>> Office of High Performance Computing and Communications
>>
>> National Library of Medicine
>>
>> blowekamp at mail.nih.gov
>>
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101218/f0229df2/attachment.htm>