[Insight-developers] "git gerrit-push" failed; confused

[Luis Ibanez]

Hi Sean,

Thanks for the patch
I just reviewed it and approved it.


For the record:

In order to add reviewers you can take names from this list:
http://review.source.kitware.com/#admin,group,5


If you type the first name (full first name), in the "Add Reviewer"
field of your patch, Gerrit will show you the matches from that
group of reviewers, and you can click on any name with the
mouse.

Once your patch is approved, you can merge it by just doing

                        git    gerrit-merge


This you can do now,
since your patch has been approved.


     Thanks


          Luis


-----------------------------------------------------
On Thu, Dec 16, 2010 at 3:08 PM, Sean McBride <sean at rogue-research.com>wrote:

> On Thu, 16 Dec 2010 14:44:37 -0500, Marcus D. Hanwell said:
>
> >You would need to register that email address with Gerrit, Settings,
> >Contact Information, Register New Email would let you add it.
>
> Dang, I knew it was going to be something stupid. :)
>
> So here it is:
> <http://review.source.kitware.com/577>
>
> Do I need to do something in the gerrit web UI?  Or is it now 'in the
> system' and someone will review/merge?
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101216/36d54285/attachment.htm>