[Insight-developers] question about CovarianceSampleFilter

[Luis Ibanez]

Arnaud, Brad,

The patch has been submitted to Gerrit:
http://review.source.kitware.com/#change,506

and the bug entry was updated:
http://public.kitware.com/Bug/view.php?id=8893


     Luis


----------------------------------------------
On Sun, Dec 5, 2010 at 10:20 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> HI Arnaud,
>
> I'm reconstructing that patch from scratch,
> but this time as a git branch    :-)
>
> It is almost ready,
> I need to iron out the tests...
>
>
>     Luis
>
>
> ---------------------------------
> On Fri, Dec 3, 2010 at 4:29 PM, Arnaud Gelas
> <Arnaud_Gelas at hms.harvard.edu> wrote:
>> Brad,
>>
>> thanks for the link!!
>>
>> ---
>>
>> Luis,
>>
>> By any chance, do you still have the patch you mentioned on Mantis?
>>
>> Thanks,
>> Arnaud
>>
>>
>> On Dec 3, 2010, at 4:25 PM, Bradley Lowekamp wrote:
>>
>>> I believe I report this bug a while back:
>>> http://public.kitware.com/Bug/view.php?id=8893
>>>
>>> On Dec 3, 2010, at 3:57 PM, Arnaud Gelas wrote:
>>>
>>>> Hi all,
>>>>
>>>> In itk::CovarianceSampleFilter, the mean is computed as the same type
>>>> as the TSample type. So if inputs are vector of unsigned char, the
>>>> mean is a vector of unsigned char...
>>>> While the mean is assumed to be as the same type as TSample, the
>>>> covariance matrix coefficients are in double, not in the same type as
>>>> the input.
>>>>
>>>> Shouldn't the mean' components in double (to be consistent with what
>>>> has been done for the covariance matrix)?
>>>>
>>>> Thanks,
>>>> Arnaud
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>
>>
>