[Insight-developers] Making Rigid3DTransform abstract

Luis Ibanez luis.ibanez at kitware.com
Fri Dec 3 13:35:13 EST 2010


Hi Bill,

Sure, I'll look at it.

What we do more recently is that the tests of abstract classes
locally declare a derived class in the test itself and use it as
a surrogate for exercising the methods of the abstract class.

I'll add that to the patch.

Removing a test will be an unfortunate way to go.


     Luis

--------------

On Fri, Dec 3, 2010 at 11:36 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Luis,
>
> This gerrit topic http://review.source.kitware.com/#change,314 needs
> some minor attention before it is acceptable. The topic seems to make
> the Rigid3DTransform abstract, as stated. Looks good to me. However,
> the test itkRigid3DTransformTest.cxx failed to compile. It is trying
> to do a ::New() on itkRigid3DTransform which now does not have a new
> method. I think the test should be removed.
>
> I metion this because this one seems to be lingering.
>
> Bill
>


More information about the Insight-developers mailing list