[Insight-developers] [master] Change Ie2bca991: (ITK) STYLE: improved style on a couple sets of if statements

[Brad King]

On 08/30/2010 11:51 AM, Bradley Lowekamp wrote:
> I am not getting the Change-Id automatically added to my fetches from gerrit.

I must have remembered that behavior incorrectly or tested it wrong
when first learning it.

> I also tried other proposed patches which out success. Given that I have
> 4 patches to update, if this could happen automatically it'd be sweet!

This time you'll have to use "rebase -i" to edit each commit message
to add the change id from the corresponding Gerrit page.  See also
here:

http://gerrit.googlecode.com/svn/documentation/2.0/user-upload.html#push_replace

> This is the hook on the review git repository which should do it?
> http://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html#creation

This hook does it when you initially create the commits.  It will
not help fix existing commits that have already been pushed to
Gerrit.  We can use this hook in the future, but right now it will
overwrite our own "hooks" branch's commit-msg hook.  Last week I
started on changes to our hooks branch to include Gerrit's hook
but have not finished yet.

> Out of curiosity would this also change the SHA?

Yes.  It's a brand new commit object that just happens to look a lot
like the old one.

-Brad