[Insight-developers] [master] Change Ica45be1d: (ITK) ENH: added an API for setting/getting the mask

[Jim Miller]

Okay. I did this...

> Assuming you've added the 'gerrit' and 'stage' remotes to your local
> repository, run these commands:
> 
> $ git fetch gerrit refs/changes/08/8/1:MaskImageFilterAPI
> $ git push stage MaskImageFilterAPI
> $ ssh git at itk.org stage ITK merge MaskImageFilterAPI


and no issues where reported and I received an nice little email

> Change Ica45be1d by Jim Miller submitted to master:
> 
> ENH: added an API for setting/getting the mask
> 
> This is an alternative API to calling SetInput2()
> ---
> M Code/BasicFilters/itkConnectedComponentImageFilter.txx
> M Code/BasicFilters/itkMaskImageFilter.h
> 2 files changed, 18 insertions(+), 1 deletion(-)
> 
> Approvals:
>  Daniel Blezek: Verified; Looks good to me, approved
> 
> -- 
> To view visit http://review.source.kitware.com/8
> To unsubscribe, visit http://review.source.kitware.com/settings
> 
> Gerrit-MessageType: merged
> Gerrit-Project: ITK
> Gerrit-Branch: master
> Gerrit-Owner: Jim Miller <millerjv at ge.com>
> Gerrit-Reviewer: Daniel Blezek <blezek.daniel at mayo.edu>


I then was able to fetch from my upstream repository at itk.org and my changes are now on the master branch.

Okay. So what just happened?

1. Did I need to fetch the patch from gerrit? Since I submitted the patch originally, it would seem as though I would already have the branch.

2. What is the ssh line doing? Why didn't I push directly to main repository at itk.org? 

3. How did I get this email about the merge? Was the patch I submitted annotated with information that gerrit recognized and it triggered the email?

4. Looking at gerrit, my patch has been closed.  How did that happen?

(Sorry if this seems mundane but I need to understand this so that I can train other people to fish.)


Jim Miller
Senior Scientist
GE Research 
Interventional and Therapy

GE imagination at work

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100827/c9f38a4a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3108 bytes
Desc: not available
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100827/c9f38a4a/attachment.bin>