[Insight-developers] [master] Change Ica45be1d: (ITK) ENH: added an API for setting/getting the mask

[Daniel Blezek]

Hi Jim,

  Brad L¹s patches were a mistake.  Gerrit only allows review of a single
commit.  What Brad needed to do was ³squash² the commits into one, using
rebase, or cherry-pick.  Then he should have submitted that single commit to
Gerrit.  Brad King and Marcus Hanwell are looking into adding a branch-level
review to Gerrit with the developers.

  So I reviewed your change (recognizing it was exploratory), and marked it
as verified.  I have no idea at all how to push into the main line.  We are
doing the same in SimpleITK, but are stuck on how Gerrit will publish the
change.  The plumbing has been put in place by Marcus, so Gerrit has write
access to the SimpleITK github repo, but I don¹t know where the ³Push this
to GitHub² button is...

Best,
-dan


On 8/27/10 9:30 AM, "Jim Miller" <millerjv at ge.com> wrote:

> (This is in reference to kicking the tires on Gerritt, a code review system.
> I constructed a small patch and submitted the patch to Gerritt which Dan has
> now verified and reviewed.)
> 
> Okay... so now what do we do?
> 
> I am also confused as to how Gerritt is being used.  It looks like people
> (both Mathieu and Brad L) have submitted multiple patches referencing the same
> topic branch.  Should each patch be a unique topic branch? Or doesn't it
> matter? 
> 
> Jim
> 
> On Aug 27, 2010, at 9:37 AM, Daniel Blezek (Code Review) wrote:
> 
>> Comments on Patch Set 1:
>> 
>> Patch Set 1: Verified; Looks good to me, approved
>> 
>> OK.
>> 
>> To respond, visit http://review.source.kitware.com/8

-- 
Daniel Blezek, PhD
Medical Imaging Informatics Innovation Center

P 127 or (77) 8 8886
T 507 538 8886
E blezek.daniel at mayo.edu

Mayo Clinic
200 First St. S.W.
Harwick SL-44
Rochester, MN 55905
mayoclinic.org
"It is more complicated than you think." -- RFC 1925

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100827/ba3748a0/attachment.htm>