[Insight-developers] Gerrit review of Change Number 24

[Mathieu Malaterre]

On Thu, Aug 26, 2010 at 4:58 PM, Brad King <brad.king at kitware.com> wrote:
>> http://review.source.kitware.com/#change,24
>
> I'll review that in Gerrit.

Hum... I must have done something wrong.


$ git add CMake/ExportConfiguration/CMakeLists.txt CMakeLists.txt
$ git commit
reading .git/COMMIT_EDITMSG

wrote .git/COMMIT_EDITMSG, 20 lines, 671 chars
[integration-gdcm-2-0-16 d2ee19d] Redo the GDCMTargets / ITKTargets handling
 2 files changed, 9 insertions(+), 1 deletions(-)
$ git push gerrit d2ee19d:refs/changes/24
Counting objects: 14, done.
Delta compression using up to 16 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 9.84 KiB, done.
Total 8 (delta 6), reused 0 (delta 0)
To malaterre at review.source.kitware.com:ITK
 ! [remote rejected] d2ee19d -> refs/changes/24 (squash commits first)
error: failed to push some refs to 'malaterre at review.source.kitware.com:ITK'

where the commit message was:

$ cat .git/COMMIT_EDITMSG
Redo the GDCMTargets / ITKTargets handling

After discussion with Brad King on gerrit, I need to handle
the case where GDCM is a subproject of -say- ITK
Ref: http://review.source.kitware.com/#change,24
Change-Id:I2f9e600d

I am following instructions from:
http://www.itk.org/Wiki/ITK/Gerrit#Making_Changes_in_Uploaded_Patches

So if I understand correctly in my case
[change id from Gerrit here] is I2f9e600d
and
[change number] is 24

Right ?

Thanks
-- 
Mathieu