[Insight-developers] DICOM warning about missing preamble

[Bradley Lowekamp]

Hello all,

Bill did you test this patch?

Should this patch be applied to the release branch too?

I just did the following: 

victoria:ITK blowek1$ git checkout -b bug_dicom_warn_preable_missing 379f25745b748bf54
Checking out files: 100% (1315/1315), done.
M	Testing/Data
Switched to a new branch 'bug_dicom_warn_preable_missing'

victoria:ITK blowek1$ git am ~/temp/0001-BUG-Warn-that-DICOM-file-is-missing-preamble-only-wh.patch 
Applying: BUG: Warn that DICOM file is missing preamble only when detected.
victoria:ITK blowek1$ git push github HEAD
Counting objects: 9, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 562 bytes, done.
Total 5 (delta 4), reused 0 (delta 0)
To git at github.com:blowekamp/ITK.git
 * [new branch]      HEAD -> bug_dicom_warn_preable_missing

You can see it on git hub:

http://github.com/blowekamp/ITK/commit/d300270b252a56a64a5246fcd4958b198b39c203
http://github.com/blowekamp/ITK/network

I am really liking git! This was really easy to do. I think this is where the true power of git comes into play, it where its really easy to share and contribute patches , bug fixes and feature enhancements. Very nice!

Brad

On Aug 15, 2010, at 11:51 AM, Bill Lorensen wrote:

> Your patch should be applied. Sloppy work on my part.
> 
> On Sun, Aug 15, 2010 at 10:22 AM, Casey Goodlett
> <casey.goodlett at kitware.com> wrote:
>> Hi Bill,
>> 
>> I'm loading a DICOM series using ITK release 3.20.0 that seems to contain a
>> valid preamble, but I'm getting a warning from the GDCM reader. In previous
>> versions of ITK this worked without a warning.
>> 
>> I'm wondering if the change at 379f25745b748bf549480f85263988254f2a030a
>> should be modified with the attached patch.  I think the warning is always
>> emitted instead of only when the preamble is missing.
>> 
>> Does this seem right?
>> 
>> Thanks
>> 
>> --
>> Casey B. Goodlett, Ph.D.
>> R&D Engineer
>> Kitware, Inc. - North Carolina Office
>> http://www.kitware.com
>> (919) 969-6990 x310
>> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

========================================================
Bradley Lowekamp  
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine 
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100818/dbc79caa/attachment.htm>