[Insight-developers] Tests failing in the Dashboard

Luis Ibanez luis.ibanez at kitware.com
Tue Oct 27 11:02:27 EDT 2009 

The two Experimental builds from the Cloud machines are now in the Dashboard.
It is clear that there are compilation problems when LEGACY_REMOVE is ON.

I'll try now removing the #ifdef for it in itkMath.h.

(unless there are other better options ....)


     Luis


--------------------------------------------------------------------------------------------------------------
On Tue, Oct 27, 2009 at 8:19 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> I'm trying to track down the problem with my local Borland build. The
> first error is:
> itkBSplineInterpolationWeightFunction.txx 130: Could not find a match
> for 'Math::Floor<TReturn,TInput>(double)' in function
> BSplineInterpolationWeightFunction<float,3,3>::Evaluate(const
> ContinuousIndex<float,3> &,Array<double> &,Index<3> &) const
>
> I looked in itkMath.h, but I can't follow the code this early in the morning.
>
> Bill
>
> On Tue, Oct 27, 2009 at 7:52 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> Brad,
>>
>> Thanks, I'll try that.
>>
>> It is still strange that it compiles find in my Ubuntu Linux
>> but not in Bill's Borland build.
>>
>> We both have LEGACY_REMOVE set to    OFF.
>>
>> I'm setting up two Experimental builds from the Amazon Cloud
>> to test the build with both settings of the flag.
>>
>>
>>    Luis
>>
>>
>> -----------------------------------------------------------------------
>> On Tue, Oct 27, 2009 at 7:48 AM, Bradley Lowekamp
>> <blowekamp at mail.nih.gov> wrote:
>>> Luis,
>>>
>>>        You probably just need to comment out the legacy remove preprocessor
>>> directives in itkMath.h.
>>>
>>> Brad
>>>
>>> On Oct 27, 2009, at 6:45 AM, Luis Ibanez wrote:
>>>
>>>> Bill,
>>>>
>>>> My commits were made after build with no compilation errors,
>>>> (that's the Experimental build from macondo.kitware).
>>>>
>>>> but it was not from a clean build (not a build from scratch).
>>>> I'm following up on the remaining issues.
>>>>
>>>>
>>>>    Luis
>>>>
>>>>
>>>>
>>>> --------------------------------------------------------------------------------------
>>>> On Mon, Oct 26, 2009 at 11:30 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>>> wrote:
>>>>>
>>>>> Luis,
>>>>>
>>>>> The dashboard wrath is getting worse after your changes. It will be a
>>>>> while before it finishes, but the BillsLaptop borland continuous is
>>>>> generating dozens of errors.
>>>>>
>>>>> I suggest we stop checking in code throughout the day until this issue
>>>>> is resolved.
>>>>>
>>>>> Bill
>>>>>
>>>>> On Mon, Oct 26, 2009 at 10:44 PM, Luis Ibanez <luis.ibanez at kitware.com>
>>>>> wrote:
>>>>>>
>>>>>> Hi Brad,
>>>>>>
>>>>>> Thanks for the clarification....
>>>>>>
>>>>>> It looks that we will have to reconsider the call for the
>>>>>> ImageBase::CopyInformation
>>>>>> method...
>>>>>>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> On a different note:
>>>>>>
>>>>>> It seems that some of your changes for itkMath were accidentally
>>>>>> committed
>>>>>> to the repository. The Dashboard is looking pretty red at this point.
>>>>>>
>>>>>>
>>>>>> I'm committing some changes to calm the wrath of the Dashboard Gods,
>>>>>>
>>>>>> but
>>>>>>
>>>>>> the source code sacrifices will only take effect for the first
>>>>>> continuous builds
>>>>>> of tomorrow morning....
>>>>>>
>>>>>> --
>>>>>>
>>>>>> These changes may not reflect what you intended to do. For example,
>>>>>> I'm including itkMath.h in itkMacro.h, and in some other files, then
>>>>>> removing from itkMacro.h the previous implementation of Math
>>>>>> functionalities.
>>>>>>
>>>>>> (This is just to get a Green Dashboard,
>>>>>>  please feel free to reorganize according to your plans,
>>>>>>  after things settle down.).
>>>>>>
>>>>>>
>>>>>>
>>>>>>     Luis
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------------------------------------------
>>>>>> On Mon, Oct 26, 2009 at 2:54 PM, Bradley Lowekamp
>>>>>> <blowekamp at mail.nih.gov> wrote:
>>>>>>>
>>>>>>> Hello Luis,
>>>>>>> The ImageBase::CopyInformation method does not support copying miss
>>>>>>> matching
>>>>>>> dimensions of meta data.
>>>>>>>
>>>>>>> The new rounding work is not being used any where besides a couple of
>>>>>>> tests.
>>>>>>> To migrate from the old rounding methods to the new, I will need to
>>>>>>> modify
>>>>>>> itkMacro.h and about 20 or so other Code files plus a few tests. When I
>>>>>>> am
>>>>>>> ready to do this large commit I will inform this mailing list the day
>>>>>>> before
>>>>>>> to help isolate potential issues.
>>>>>>> Brad
>>>>>>>
>>>>>>>
>>>>>>> On Oct 26, 2009, at 2:32 PM, Bill Lorensen wrote:
>>>>>>>
>>>>>>> This one is real. The Borland compiler is the only one that reports
>>>>>>> divide by floating point 0.
>>>>>>> http://www.cdash.org/CDash/testDetails.php?test=34297691&build=456734
>>>>>>>
>>>>>>> This one is directly caused by the CopyInformation add. Something to
>>>>>>> do with the dynamic cast. Probably becuase input and output dimensions
>>>>>>> in the test change.
>>>>>>>
>>>>>>> Bill
>>>>>>>
>>>>>>> On Mon, Oct 26, 2009 at 2:12 PM, Luis Ibanez <luis.ibanez at kitware.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> In today's continuous builds we have several failing tests,
>>>>>>>
>>>>>>> but they are not consistent across builds.
>>>>>>>
>>>>>>> Suspect causes are:
>>>>>>>
>>>>>>> My commits of:
>>>>>>>
>>>>>>> http://www.cdash.org/CDash/viewUpdate.php?buildid=456734
>>>>>>>
>>>>>>> * itkUnaryFunctorImageFilter
>>>>>>>
>>>>>>> * itkOptMattesMutualInformationImageToImageMetric.txx
>>>>>>>
>>>>>>>
>>>>>>> Please let me know if you see any other potential
>>>>>>>
>>>>>>> reasons for the failing tests.
>>>>>>>
>>>>>>> Otherwise, I will mostly suspect of a secondary effect
>>>>>>>
>>>>>>> of the change in the itkUnaryFunctorImageFilter...
>>>>>>>
>>>>>>>
>>>>>>>   Thanks
>>>>>>>
>>>>>>>
>>>>>>>         Luis
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>>
>>>>>>> Powered by www.kitware.com
>>>>>>>
>>>>>>> Visit other Kitware open-source projects at
>>>>>>>
>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>
>>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>>>
>>>>>>> http://kitware.com/products/protraining.html
>>>>>>>
>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>>
>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>
>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>>
>>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Powered by www.kitware.com
>>>>>>>
>>>>>>> Visit other Kitware open-source projects at
>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>
>>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>>> http://kitware.com/products/protraining.html
>>>>>>>
>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>
>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>>>
>>>>>>> ========================================================
>>>>>>>
>>>>>>> Bradley Lowekamp
>>>>>>>
>>>>>>> Lockheed Martin Contractor for
>>>>>>>
>>>>>>> Office of High Performance Computing and Communications
>>>>>>>
>>>>>>> National Library of Medicine
>>>>>>>
>>>>>>> blowekamp at mail.nih.gov
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>
>>>
>>
>

More information about the Insight-developers mailing list