[Insight-developers] redefinition of HAVE_SYS_TYPES_H and HAVE_STDINT_H

[Gaëtan Lehmann]

Le 20 nov. 09 à 14:01, Bradley Lowekamp a écrit :

>
> On Nov 20, 2009, at 6:22 AM, Mathieu Malaterre wrote:
>
>> 2009/11/20 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>>
>>> Brad,
>>>
>>> Two of the definitions you have added in
>>>
>>> http://public.kitware.com/cgi-bin/viewcvs.cgi/itkConfigure.h.in?root=Insight&view=diff&r1=1.34&r2=1.35
>>>
>>> , HAVE_SYS_TYPES_H and HAVE_STDINT_H, seems to be already used by  
>>> python. A
>>> lot of warning are produced while building wrapitk because of that:
>>>
>>> http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=475515
>>>
>>> Would it be ok for you if I add them an ITK_ prefix?
>>
>> There had been a discussion whether or not #cmakedefine BLA should  
>> produce
>>
>> #ifndef BLA
>> #define BLA
>> #endif
>>
>> Adding blocker around culprit should be easy...
>>
>> -- 
>> Mathieu
>
>
> But if  itkConfigure.h is included before phython then it wont work,  
> because phython is not ifndef. I think what may be needed is similar  
> to the following:
>
> #if @HAVE_STDINT_H@
> #define ITK_HAVE_STDINT_H
> #endif
>
> I'd need to look at what the value of @HAVE_STDINT_H@ would be. By  
> doing this we can use the standard naming inside CMAKE, and convert  
> it to our own in the ITK code.


Why not using directly the ITK_ prefix in cmake?
The chance to have a collision in that case seems quite low.

Am I missing something?

Gaëtan

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20091123/07182782/attachment.pgp>