[Insight-developers] ITK 3.14 Release and Rounding Patch

[Luis Ibanez]

Hi Tom,


We appreciate a lot the effort that you are investing in helping us
fix this problem.


As Wes described, we are testing the patch that you submitted today.


One Experimental build (from scratch) with the patch applied has
been submitted from "macondo.kitware".

                 Linux-g++-4.2-RoundPatch

The build is green.


We have also several Experimental builds underway from Mac, and
from Windows with Visual Studio 7.1 and 9.


Note that all these Experimentals are using the default set of
parameters in the CMake configuration.


If the Experimental builds continue to look promising we will
commit the patch, probably by early afternoon.



    Thanks


       Luis


----------------------
Tom Vercauteren wrote:
> Reposting without the patch to meet the size limit. The patch is now
> on the bug tracker:
> http://www.itk.org/Bug/file_download.php?file_id=2269&type=bug
> 
> -----------------
> Folks,
> 
> Attached is a patch that does the following:
> - handles the three points I initially mentioned
>    * remove ITK_USE_PORTABLE_ROUND
>    * check for x86 in gcc asm implementation of rounding
>    * add floor and ceil and use them in lieu of the buggy private
> fast floor function
> - adds a unit test for itk::Math function
> - fixes and enhances itkMathRoundProfileTest1
> - solves the small cmake issue of ResampleImageFilter3Test1
> 
> Feel free to use only part of it. If you want I can also split it so
> as to cover only what you want to commit for the release.
> 
> The experimental build corresponding to the entire patch with
> ITK_USE_CENTERED_PIXEL_COORDINATES_CONSISTENTLY turned off is green on
> my machine:
> http://www.cdash.org/CDash/buildSummary.php?buildid=341090
> 
> Cheers,
> Tom
> 
>