[Insight-developers] Insight-developers Digest, Vol 61, Issue 31

[Simon Warfield]

Dear Luis,

Either option A or B make sense to me.

At the moment, the patch to fix the bug of non- portable rounding,  
which is critical for indexes to be calculated the same way across 
platforms, is not fully satisfactory.
The current patch ensures inconsistent cross-platform behavior if 
ITK_USE_PORTABLE_ROUND is not selected.
This would be appropriate if we were selecting to turn on or off some 
feature, but here it is being used to turn on or off correct behavior.
> Let me propose two options:
>
>
>
>     A) We commit your patch, and post-pone the release
>        until next Saturday.
>
>        This will give us time to verify the all builds
>        are correct
>
>
>
>     B) We hold on the patch. Cut the release as scheduled.
>        and commit the patch immediately after the repository
>        reopens.
>
>        Once the dashboard stabilizes, we cut a patch release
>        ITK 3.14.1.
>
>
>
>
> If we are going to proceed with (A),
> we should at least see an Experimental build first.
>
>
>
>     What other developers think ?
>
>
>        Luis
>
>
>
>
>   

--
Simon