[Insight-developers] (no subject)

[M.Staring at lumc.nl]

Thanks for the clarification,
 
Marius


________________________________

	From: Bradley Lowekamp [mailto:blowekamp at mail.nih.gov] 
	Sent: Tuesday, May 19, 2009 5:48 PM
	To: Staring, M. (LKEB)
	Cc: insight-developers at itk.org
	Subject: Re: [Insight-developers] (no subject)
	
	
	These changes are related to the following bug: 
	http://www.itk.org/Bug/view.php?id=8729

	This class is almost stream-able. Some work needs to be done to
make it work. But the remainder of that function needs to be modified to
support it correctly. Please note the fixme later in the functions.
	 

	On May 19, 2009, at 11:20 AM, M.Staring at lumc.nl wrote:


		Hi,
		 
		In the CannyEdge filter the function
GenerateInputRequestedRegion is overridden. 7 years ago a return
statement was included just after calling the superclass implementation
of GenerateInputRequestedRegion
		 
	
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkCannyEdgeDet
ectionImageFilter.txx?root=Insight&r1=1.17&r2=1.18&sortby=date
		 
		Since then the rest of this function was never called.
		 
		Assuming that this return is valid the whole override
can be removed from this class, since only the superclass implementation
is used. This will increase code coverage for this file.
		 
		Otherwise it's a bug.
		 
		With kind regards,
		 
		Marius Staring
		Division of Image Processing (LKEB)
		Department of Radiology
		Leiden University Medical Center
		PO Box 9600, 2300 RC Leiden, The Netherlands
		phone: +31 (0)71 526 1105, fax: +31 (0)71 526 6801
		m.staring at lumc.nl
		 
		<ATT00001.txt>


	
	========================================================

	Bradley Lowekamp  

	Lockheed Martin Contractor for

	Office of High Performance Computing and Communications

	National Library of Medicine 

	blowekamp at mail.nih.gov



	No virus found in this incoming message.
	Checked by AVG - www.avg.com
	Version: 8.5.329 / Virus Database: 270.12.34/2122 - Release
Date: 05/19/09 06:21:00
	

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090519/5fb937be/attachment.htm>