[Insight-developers] (no subject)

M.Staring at lumc.nl M.Staring at lumc.nl
Tue May 19 11:20:26 EDT 2009


Hi,
 
In the CannyEdge filter the function GenerateInputRequestedRegion is
overridden. 7 years ago a return statement was included just after
calling the superclass implementation of GenerateInputRequestedRegion
 
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkCannyEdgeDet
ectionImageFilter.txx?root=Insight&r1=1.17&r2=1.18&sortby=date
 
Since then the rest of this function was never called.
 
Assuming that this return is valid the whole override can be removed
from this class, since only the superclass implementation is used. This
will increase code coverage for this file.
 
Otherwise it's a bug.
 
With kind regards,
 
Marius Staring
Division of Image Processing (LKEB)
Department of Radiology
Leiden University Medical Center
PO Box 9600, 2300 RC Leiden, The Netherlands
phone: +31 (0)71 526 1105, fax: +31 (0)71 526 6801
m.staring at lumc.nl
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090519/98fd271e/attachment.htm>


More information about the Insight-developers mailing list