[Insight-developers] Suspicious method name in LabelMapToLabelImageFilter

[Wes Turner]

It helps to be away for the weekend.  By the time I get back, all of
this is resolved.  Sorry for not catching this when I was checking it
in.

Bill: Are you happy with the resolution?

- Wes

2009/5/17 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>
> Hi Luis,
>
> Le 17 mai 09 à 03:41, Luis Ibanez a écrit :
>
>>
>> My apologies,
>> I just read this thread...
>>
>>
>> The name of the method was renamed three hours ago.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Review/itkLabelMapToLabelImageFilter.h?root=Insight&r1=1.1&r2=1.2&sortby=date
>>
>> Replaced:
>> ThreadedGenerateData
>>
>> with:
>> ThreadedProcessLabelObject
>>
>
> It looks good enough for me :-)
>
> Gaëtan
>
>
>> to solve the warning about hidden virtual method.
>>
>> Please feel free to replace the name with something
>> more appropriate.
>>
>>
>>        Luis
>>
>>
>>
>> --------------------------------------------------------------------------------
>> On Sat, May 16, 2009 at 3:56 PM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>> Now I see. The Superclass has a ThreadedGenerateData with the proper
>> signature which invokes the suspicious method. It should have a
>> different name. AFAIKT, this would be the only class in ITK that has a
>> method named ThreadedGenerateData with a different signature. Let me
>> sleep on this to come up with a better name.
>>
>> Bill
>>
>>
>> 2009/5/16 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>> >
>> > Le 16 mai 09 à 21:37, Bill Lorensen a écrit :
>> >
>> >> But it seems to be missing the second argument that all other
>> >> ThreadedGenerateData have.
>> >
>> > because I didn't saw any useful case where the thread id can be used.
>> >
>> > On second thought, this ThreadedGenerateData is different of the other,
>> > because it is called once per object, and not once per thread.
>> > A thread generally process several objects.
>> >
>> > Any idea for a better name?
>> >
>> >
>> >>
>> >>
>> >> 2009/5/16 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>> >>>
>> >>> Le 16 mai 09 à 21:24, Bill Lorensen a écrit :
>> >>>
>> >>>> Wes and Gaëtan,
>> >>>>
>> >>>> This build:
>> >>>> http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=333969
>> >>>>
>> >>>> warns about LabelMapToLabelImageFilter<TInputImage,
>> >>>> TOutputImage>::ThreadedGenerateData(typename
>> >>>> TInputImage::LabelObjectType*) shadowing the method void
>> >>>> itk::LabelMapFilter<TInputImage,
>> >>>> TOutputImage>::ThreadedGenerateData(const typename
>> >>>> TOutputImage::RegionType&, int).
>> >>>>
>> >>>> The former is a very unique signature for ThreadedGenerateData.
>> >>>>
>> >>>
>> >>> Hi Bill,
>> >>>
>> >>> It's a ThreadedGenerateData which work on a LabelObject (a subpart of
>> >>> a
>> >>> LabelMap) instead of working on a subregion of an Image.
>> >>> The name looks quite good to me.
>> >>>
>> >>> Do you think that another name may be better?
>> >>>
>> >>> Gaëtan
>> >>>
>> >>> --
>> >>> Gaëtan Lehmann
>> >>> Biologie du Développement et de la Reproduction
>> >>> INRA de Jouy-en-Josas (France)
>> >>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> >>> http://voxel.jouy.inra.fr  http://www.mandriva.org
>> >>> http://www.itk.org  http://www.clavier-dvorak.org
>> >>>
>> >>>
>> >
>> > --
>> > Gaëtan Lehmann
>> > Biologie du Développement et de la Reproduction
>> > INRA de Jouy-en-Josas (France)
>> > tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> > http://voxel.jouy.inra.fr  http://www.mandriva.org
>> > http://www.itk.org  http://www.clavier-dvorak.org
>> >
>> >
>>
>
> --
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.mandriva.org
> http://www.itk.org  http://www.clavier-dvorak.org
>
>



-- 
Wesley D. Turner, Ph.D.
Kitware, Inc.
R&D Engineer
28 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-371-3971 x120