[Insight-developers] TransformFileReaderWithFactory inconsistent interface

[Bill Lorensen]

Another point. I would prefer that the m_ variables be private rather
than protected. Access to them can be made using Get methods.

I have made local changes to do this. Can I check them in?

Bill

On Sun, May 10, 2009 at 2:58 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> I would prefer to return a const reference. Returning a raw pointer is
> dangerous in general. Also, why is the ivar called m_ReadTransformList
> and not m_TransformList? The latter corresponds to the Get name.
>
> Bill
>
> On Sun, May 10, 2009 at 1:59 PM, Vincent Magnotta
> <vincent-magnotta at uiowa.edu> wrote:
>> Hans,
>>
>> I would suggest the later since it makes the signature a little more clear.
>> Most of the C++ references that I reviewed, most use this type of signature.
>>
>> Vince
>>
>>
>>
>> On 5/10/09 10:26 AM, "Hans Johnson" <hans-johnson at uiowa.edu> wrote:
>>
>> Vince,
>>
>> There has been some discusssion of moving the TransformIO from the Review
>> directory.  I am fully in favor of this.  I did, however, notice an
>> inconsistency in the member function signatures that would be nice to clear
>> up before the transition occurs (and we are locked in to backwards
>> compatibility).
>>
>> itkTransformFileReaderWithFactory.h:  TransformListType * GetTransformList()
>> {return & m_TransformList;}
>> itkTransformIOBase.h:  TransformListType &GetTransformList() { return
>> m_ReadTransformList; }
>>
>> Could you please give some advice on which signature should be used?
>>
>> Thanks,
>> Hans
>>
>>
>> ----------------------
>> Associate Professor
>> Department of Radiology
>> 0453-D JCP
>> 200 Hawkins Drive
>> Iowa City, IA 52242
>> E-mail: vincent-magnotta at uiowa.edu
>> Phone: 319-356-8255 Fax: 319-353-6275
>> Website: http://www.radiology.uiowa.edu
>>
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>