[Insight-developers] Functors Constness (Mantis bug http://public.kitware.com/Bug/view.php?id=8678)

[Tom Vercauteren]

Hi Kent,

I didn't add any duplicate modified functor in review. I simply
changed the functors that were already in review and made their
operator() const. The same modification should be done in the main
trunk.

Tom

On Thu, Mar 26, 2009 at 23:14, kent williams
<norman-k-williams at uiowa.edu> wrote:
> I was looking at unassigned bugs today for low-hanging fruit and this one
> caught my eye:
>
>    A reported on the list, operator() defined in ITK functors should be
> const:
>
> http://public.kitware.com/pipermail/insight-users/2009-February/029212.html
>
>    >> On Tue, Feb 24, 2009 at 8:15 AM, Julien Michel <julien.michel at c-s.fr>
> wrote:
>    >> It prevents me from reusing them inside some const methods, and it
> looks like
>    >> they could have been declared const without any problem. Mutable does
> the
>    >> trick, but I would rather avoid it if possible.
>
> It appears Tom Vercauteren checked in modified files to review to make
> operator() const in all functors.  Now that 3.12 is released, what needs to
> happen to make it possible to move these files from review to release?
>
> For that matter, if I turn on ITK_USE_REVIEW, do those files get included in
> preference to the ones checked in on the trunk, or do I need to copy them
> out to the main directory, build, and then test them?
>
>
>
>
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>