[Insight-developers] itkResampleImageFilter.h & itkWarpImageFilter.h and Software Archeology

Gaëtan Lehmann gaetan.lehmann at jouy.inra.fr
Wed Mar 25 13:50:31 EDT 2009



Hi Luis,

Nothing much to say about all of that, but

Le 25 mars 09 à 18:43, Luis Ibanez a écrit :

> If Backward-Compatibility wasn't a factor, I will suggest
>
>    - Remove the SetOutputParametersFromConstImage() method.
>      There was no reason for adding such method, when the
>      same effect can be achieved by simply using a const raw
>      pointer in the SetOutputParametersFromImage() method.
>
>    - Make the SetOutputParametersFromImage() take a const
>      raw pointer (not a smart pointer).
>
>    - Solve the ambiguity and duplication of functionality
>      between the SetReference() image and the
>      SetOutputParametersFromImage() methods.
>
>
>  I'm not sure that we can clean up this in a way that
>  is consistent at this point...
>
>  We could deprecate the ConstImage() method, but since deprecation
>  doesn't imply removal, we have to maintain it anyways...

It would be nice to put that in the desirable non backward compatible  
changes, in the ITK 4.0 page on the wiki.

>
>
>
> ------
>
>
>
>  Being positive and looking to the Future:
>  ==========================================
>
>
>  It looks like we *MUST* implement some sort of
>  *systematic* code-review practice.

Yes, it would be great, but we may have a similar problem than with IJ  
contributions...

Regards,

Gaëtan

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.mandriva.org
http://www.itk.org  http://www.clavier-dvorak.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090325/bc67a59c/attachment.pgp>


More information about the Insight-developers mailing list