[Insight-developers] NaryFunctorImageFilter starts by clearing its output - any reason for that?

[Luis Ibanez]

Hi Tom,

Thanks for pointing this out.

I agree with you in that this code seems to be unnecessary,

and it is certainly inconvenient when running InPlace  :-)

Removing that initialization sounds good...

Although only running an Experimental build
will tell us for sure...


    Luis



----------------------
Tom Vercauteren wrote:
> Hi all,
> 
> I just filed a bug report about NaryFunctorImageFilter not being able
> to run inplace:
> http://www.itk.org/Bug/view.php?id=8672
> 
> The reason is that NaryFunctorImageFilter::ThreadedGenerateData starts
> by clearing the output data:
> 
>   // Clear the content of the output
>   outputIt.GoToBegin();
>   while( !outputIt.IsAtEnd() )
>     {
>     outputIt.Set( itk::NumericTraits< OutputImagePixelType >::Zero );
>     ++outputIt;
>     }
> 
> Hence if the filter is run in place, it starts by clearing its first input.
> 
> Is there a good reason for this clearing or may I just go an remove that step?
> 
> Regards,
> Tom
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>