[Insight-developers] Changes to itkOptImageToImageMetric causing crashes

[Stephen Aylward]

Hi,

It is great that you did find the other bug and fixed it.   I don't think we
should roll-back the changes...I'm sure your changes helped solve some
problems, but I think they may have revealed another problem.

We just need to dig a bit.

Stephen

On Fri, Jun 26, 2009 at 4:56 PM, Hans Johnson <hans-johnson at uiowa.edu>wrote:

>  Stephen,
>
> Those changes were made in order to fix the bug reported in
> http://public.kitware.com/Bug/view.php?id=9139  to resolve a segmentation
> fault that I was getting.  I tested that the original tests passed
> regression tests with the change, and I added a test that fails without the
> bug fix changes.
>
>
> I will not be able to work on this for the next 2 weeks, but if it is
> determined that the changes need to be rolled back, then I need to know so
> that I can figure out some other way to avoid the segmentation fault.
>
> Hans
> --
> Hans J. Johnson, Ph.D.
> Hans-johnson at uiowa.edu
>
> 278 GH
> The University of Iowa
> Iowa City, IA 52241
> (319) 353 8587
>
>
> ------------------------------
> *From: *Stephen Aylward <stephen.aylward at kitware.com>
> *Date: *Fri, 26 Jun 2009 16:28:40 -0400
> *To: *ITK <insight-developers at itk.org>
> *Subject: *[Insight-developers] Changes to itkOptImageToImageMetric
> causing crashes
>
>
>
> Hi,
>
> Registration code that use to work is now failing.
>
> When I back-out recent changes to the base image-to-image metric class, the
> code starts working again.
>
> The suspect changes are shown here:
>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Review/itkOptImageToImageMetric.txx?root=Insight&r1=1.29&r2=1.30&sortby=date
>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Review/itkOptImageToImageMetric.h?root=Insight&r1=1.22&r2=1.23&sortby=date
>
> The failure I am getting is "joint pdf sums to zero."   It only happens
> when I pass the samples to the metric.
>
> Luis and I have encountered another group with different registration code
> and that registration code has also recently started failing.  We are not
> certain if the cause is the same.
>
> I am traveling the next week, so if someone discovers the bug before me...
> :)
>
> Stephen
>
> --
> Stephen R. Aylward, Ph.D.
> Director of Medical Imaging
> Kitware, Inc. - North Carolina Office
> http://www.kitware.com
> (518) 371-3971 x300 (NY Line)
> (919) 969-6990 x300 (NC Line)
> stephen.aylward (Skype)
>
> ------------------------------
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 
Stephen R. Aylward, Ph.D.
Director of Medical Imaging
Kitware, Inc. - North Carolina Office
http://www.kitware.com
(518) 371-3971 x300 (NY Line)
(919) 969-6990 x300 (NC Line)
stephen.aylward (Skype)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090626/71d0812f/attachment.htm>