[Insight-developers] PixelTypes in BinaryImageToLabelMapFilter

[Bill Lorensen]

I was just commenting that we always have appended Value up until this
time. We can't change the old classes. If we change now, will this be
more confusing? I don't know...

On Wed, Jul 8, 2009 at 5:29 PM, Luis Ibanez<luis.ibanez at kitware.com> wrote:
>
> Bill,
>
> Are you voting for keeping the word "Value" in the
> names of these two variables ?
>
>
> My original point was to include the term "Input"
> and "Output" because the variables refer indeed to
> two different things, and otherwise, in the absence
> of the "Input" and "Output" strings in the name it
> would be easy for a user to assume that they refer
> both to the input or both to the output.
>
>
> I'll wait until tomorrow before doing any renaming,
> so we can reach some concensus.
>
>
>
>    Thanks
>
>
>
>        Luis
>
>
>
> --------------------------
> Bill Lorensen wrote:
>>
>> I just did a quick scan of itk with find. Currently in itk,
>>
>> m_ForegroundValue appears in about 16 classes (including 6 in Review).
>> m_InputForegroundValue appears in 2
>> (BasicFIlters/itkSimpleContourExtractorImageFIlter.h and its optimized
>> version in Review)
>>
>> m_InputForeground does not appear, nor does m_Foreground.
>>
>> On Wed, Jul 8, 2009 at 11:42 AM, Luis Ibanez<luis.ibanez at kitware.com>
>> wrote:
>>
>>> Hi Gaetan,
>>>
>>> We are preparing to move into Code/Review the class
>>>
>>>  itkBinaryImageToLabelMapFilter
>>>
>>> from your paper
>>>
>>>   http://hdl.handle.net/1926/584
>>>   http://www.insight-journal.org/browse/publication/176
>>>
>>> and we are looking at the declarations of
>>>
>>>    itkSetMacro(BackgroundValue, OutputPixelType);   versus
>>>    itkSetMacro(ForegroundValue, InputPixelType);
>>>
>>> at first sight it we were expecting both values to refer
>>> to the same pixel type.
>>>
>>> Looking at the code, the background value is used to  set
>>> the background value of the output LabelMap, and to
>>> make comparisons against an unsigned long int.
>>>
>>> The foreground value, on the other hand, is used for comparisons
>>> against input image pixels.
>>>
>>> Can we suggest to rename this variables as:
>>>
>>>        OutputBackgroundValue  and
>>>        InputForegroundValue
>>>
>>>
>>> Please let us know if you see a drawback to this change,
>>>
>>>
>>>    Thanks
>>>
>>>
>>>          Luis
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>>
>>
>>
>