[Insight-developers] PixelTypes in BinaryImageToLabelMapFilter

[Gaëtan Lehmann]

Le 8 juil. 09 à 19:33, Bill Lorensen a écrit :

> I just did a quick scan of itk with find. Currently in itk,
>
> m_ForegroundValue appears in about 16 classes (including 6 in Review).
> m_InputForegroundValue appears in 2
> (BasicFIlters/itkSimpleContourExtractorImageFIlter.h and its optimized
> version in Review)
>
> m_InputForeground does not appear, nor does m_Foreground.

Yes, that's why I've used ForegroundValue in my code.
But if the name is acceptable without "Value", and given the backward  
policy of ITK, it may be a good option to use that shorter name now.

I'm not able to make a decision - I just ask, and I let you, better  
english speakers and more experimented developers, make the decision :-)

Gaëtan



>
> On Wed, Jul 8, 2009 at 11:42 AM, Luis  
> Ibanez<luis.ibanez at kitware.com> wrote:
>>
>> Hi Gaetan,
>>
>> We are preparing to move into Code/Review the class
>>
>>    itkBinaryImageToLabelMapFilter
>>
>> from your paper
>>
>>     http://hdl.handle.net/1926/584
>>     http://www.insight-journal.org/browse/publication/176
>>
>> and we are looking at the declarations of
>>
>>      itkSetMacro(BackgroundValue, OutputPixelType);   versus
>>      itkSetMacro(ForegroundValue, InputPixelType);
>>
>> at first sight it we were expecting both values to refer
>> to the same pixel type.
>>
>> Looking at the code, the background value is used to  set
>> the background value of the output LabelMap, and to
>> make comparisons against an unsigned long int.
>>
>> The foreground value, on the other hand, is used for comparisons
>> against input image pixels.
>>
>> Can we suggest to rename this variables as:
>>
>>          OutputBackgroundValue  and
>>          InputForegroundValue
>>
>>
>> Please let us know if you see a drawback to this change,
>>
>>
>>      Thanks
>>
>>
>>            Luis
>>
>>
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090708/90e59661/attachment.pgp>