[Insight-developers] PixelTypes in BinaryImageToLabelMapFilter

[Luis Ibanez]

Hi Gaetan,

We are preparing to move into Code/Review the class

   itkBinaryImageToLabelMapFilter

from your paper

    http://hdl.handle.net/1926/584
    http://www.insight-journal.org/browse/publication/176

and we are looking at the declarations of

     itkSetMacro(BackgroundValue, OutputPixelType);   versus
     itkSetMacro(ForegroundValue, InputPixelType);

at first sight it we were expecting both values to refer
to the same pixel type.

Looking at the code, the background value is used to  set
the background value of the output LabelMap, and to
make comparisons against an unsigned long int.

The foreground value, on the other hand, is used for comparisons
against input image pixels.

Can we suggest to rename this variables as:

         OutputBackgroundValue  and
         InputForegroundValue


Please let us know if you see a drawback to this change,


     Thanks


           Luis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090708/46823c96/attachment.htm>