[Insight-developers] ITK 3.12: FREEZING TODAY

Wed Feb 25 17:19:34 EST 2009

There also warnings:
http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=279512

There may be more. Please watch the dashboard on all platforms.

My point is, that last minute additions to the release can have lots
of side-effects. Now we need to monitor the portability, coverage,
valgrind, etc. for this new code.

Bill

On Wed, Feb 25, 2009 at 4:47 PM, Andinet Enquobahrie
<andinet.enqu at kitware.com> wrote:
> Bill-
>
> Units tests are now set up for the two filters using the DSA dataset
> (cerebral  circulation ) contributed
> by Luca.
>
> -Andinet
>>
>> Even though they compile now, these two filters have no tests other
>> than a print test.  The coverage is really low. I think we should yank
>> them from this release and spend a little effort to bring up the
>> coverage.
>>
>>
>> http://www.cdash.org/CDash/viewCoverageFile.php?buildid=279203&fileid=10033069
>>
>> http://www.cdash.org/CDash/viewCoverageFile.php?buildid=279203&fileid=10033022
>>
>> Unfortunately, there is precedent to release code in Review with low
>> coverage, but we should not encourage more.
>>
>> Bill
>>
>> On Wed, Feb 25, 2009 at 3:33 PM, Luis Ibanez <luis.ibanez at kitware.com>
>> wrote:
>>
>>>
>>> Bill, Luca,
>>>
>>> Yes, that piece was a bit confusing.
>>>
>>> My reasoning was:
>>>
>>> The type is used to define the Eigen values of the Hessian,
>>> that happens to be the input image type.
>>>
>>> Therefore the length of the array that will store the eigenvalues
>>> must match the dimension of the image.
>>>
>>> Typically the pixel type of a Hessian Image will be a symmetric
>>> second rank tensor, in which case the "Dimension" still refers to
>>> the dimension of the space in which the image is embedded.
>>>
>>>
>>> Luca:
>>>  Is this consistent with the intention you had in this code ?
>>>
>>>
>>>
>>>    Thanks for any hint,
>>>
>>>
>>>         Luis
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------------------------
>>> On Wed, Feb 25, 2009 at 3:04 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>> wrote:
>>>
>>>>
>>>> Luis,
>>>>
>>>> I think these changes:
>>>>
>>>>
>>>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Review/itkHessianToObjectnessMeasureImageFilter.h?root=Insight&r1=1.1&r2=1.2&sortby=date
>>>>
>>>> do not match the original intent. The  EigenValueArrayType used
>>>> InputPixelType::Dimension. The changes are the equivalent of using
>>>> InputImageType::ImageDimension. The dimension is of the pixeltype not
>>>> the imagetype.
>>>>
>>>> Bill
>>>>
>>>> On Wed, Feb 25, 2009 at 2:07 PM, Luis Ibanez <luis.ibanez at kitware.com>
>>>> wrote:
>>>>
>>>>>
>>>>> Hi Bill,
>>>>>
>>>>> We are addressing the issues in Borland and VS6...
>>>>> but if it start taking too long, we can simply remove the new files.
>>>>>
>>>>> I can't wait to be able to install Visual Studio 6.0 in a computer
>>>>> in the Amazon cloud...    :-)
>>>>>
>>>>>
>>>>>    Luis
>>>>>
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>> On Wed, Feb 25, 2009 at 12:17 PM, Bill Lorensen
>>>>> <bill.lorensen at gmail.com>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> Are we comfortable freezing if code was just checked into Review
>>>>>> yesterday? I suggest we remove the new stuff that was checked in for
>>>>>> now, even though it is in Review. Borland as well as VS6 has
>>>>>> problems. I made sure before I went away to have a clean VS6 build.
>>>>>>
>>>>>> Bill
>>>>>>
>>>>>> On Wed, Feb 25, 2009 at 11:59 AM, Bill Lorensen
>>>>>> <bill.lorensen at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>> You will also need to use itkGetStaticConstMacro for the static const
>>>>>>> that is declared in that header. This is standard practice for
>>>>>>> Borland.
>>>>>>>
>>>>>>> I have restarted my continuous for a couple of days.
>>>>>>>
>>>>>>> Bill
>>>>>>>
>>>>>>> On Wed, Feb 25, 2009 at 11:55 AM, Luis Ibanez
>>>>>>> <luis.ibanez at kitware.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> Hi Bill,
>>>>>>>>
>>>>>>>> Yeap, we are tracking those.
>>>>>>>>
>>>>>>>> They seem to be related to the direct use of ImageType::Dimension.
>>>>>>>> We are replacing it with the dimension declaration extracted with
>>>>>>>> the
>>>>>>>> GetImageDimension helper class.
>>>>>>>>
>>>>>>>>
>>>>>>>>    Luis
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------
>>>>>>>> On Wed, Feb 25, 2009 at 11:40 AM, Bill Lorensen
>>>>>>>> <bill.lorensen at gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Recent checkins to Review have broken the Borland build. This
>>>>>>>>> should
>>>>>>>>> be repaired. I cannot help at this moment.
>>>>>>>>>
>>>>>>>>> On Wed, Feb 25, 2009 at 10:34 AM, Bradley Lowekamp
>>>>>>>>> <blowekamp at mail.nih.gov> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I am building an experimental with the fix for this (and the
>>>>>>>>>> ImageIORegion
>>>>>>>>>> M-D to N-D conversion issues):
>>>>>>>>>>
>>>>>>>>>> http://public.kitware.com/Bug/view.php?id=8369
>>>>>>>>>> After that I am good :)
>>>>>>>>>>
>>>>>>>>>> On Feb 25, 2009, at 10:04 AM, Luis Ibanez wrote:
>>>>>>>>>>
>>>>>>>>>> Unless anyone has a strong objection, we will be freezing
>>>>>>>>>> the cvs repository today in order to clean up the last
>>>>>>>>>> details before we cut the release of ITK 3.12 on Saturday.
>>>>>>>>>>
>>>>>>>>>> Objections anyone ?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>    Thanks
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>       Luis
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Powered by www.kitware.com
>>>>>>>>>>
>>>>>>>>>> Visit other Kitware open-source projects at
>>>>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>>>>
>>>>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>>>>
>>>>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Powered by www.kitware.com
>>>>>>>>>>
>>>>>>>>>> Visit other Kitware open-source projects at
>>>>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>>>>
>>>>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>>>>
>>>>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>
>>>>>
>>>
>>>
>>
>>
>
>
> --
> ==========================================================
> Andinet A. Enquobahrie, PhD
> R&D Engineer
> Kitware Inc.
>
> 28 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-371-3971 x124
> www.kitware.com
>
>
>