[Insight-developers] KWStyle broken

[Julien Jomier]

Hi Brad,

There seems to be a bug in kwsys's glob function that prevents us to use 
the 'itk[A-H]*.txx'. As far as I know there is no easy fix, except 
fixing the current style in Code/Common. I know Luis and Bill have been 
working on this lately. When the Code/Common directory is clean we can 
restore the glob function to itk*.txx.

I am open to suggestions,
Julien

Bradley Lowekamp wrote:
> Hello all,
> 
> Did we ever come up with a solution to this problem?
> 
> I can see it's on the dash board as this is the output of KWStyle:
> 
> *Build command: *KWStyle
> *Start Time: *2009-02-08T03:20:54 EST
> *End Time: *2009-02-08T03:21:06 EST
> 
> Brad
> 
> 
> On Feb 4, 2009, at 4:17 PM, Julien Jomier wrote:
> 
>> It seems that KWSys glob function doesn't recognize the 'itk[A-H]*.txx'
>> glob expression.
>>
>> Julien
>>
>> Bradley Lowekamp wrote:
>>> Bill,
>>>
>>> I have the lastest CVS version of KWStyle and all the tests for it
>>> passed. The file Insight/Utilities/KWStyle/ITKOverwrite.txt contains
>>> line like the following:
>>>
>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk[A-H]*.txx
>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk[A-H]*.cxx
>>> ...
>>>
>>> My KWStyle is ignoring this type of globbing line,  when I swap it with:
>>>
>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk*.h
>>>
>>> it works fine. The cmake configuration file pass this file to KWStyle
>>> with the -D argument.
>>>
>>> Brad
>>>
>>>
>>> On Feb 4, 2009, at 4:02 PM, Bill Lorensen wrote:
>>>
>>>> Brad,
>>>>
>>>> Which file gave the problem?
>>>>
>>>> Bill
>>>>
>>>> On Wed, Feb 4, 2009 at 3:41 PM, Bradley Lowekamp
>>>> <blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>> wrote:
>>>>> Hello all,
>>>>> I am not sure why but my KWStyle is not able to process the [A-Z] style
>>>>> globbing in ITKFiles.txt. The behavior of KWStyle is to ignore those
>>>>> expressions. So the make targets and the test are not really being
>>>>> run for
>>>>> these targets. Only CVS gave me errors when I tried to check in.
>>>>> Brad
>>>>>
> ========================================================
> 
> Bradley Lowekamp  
> 
> Lockheed Martin Contractor for
> 
> Office of High Performance Computing and Communications
> 
> National Library of Medicine 
> 
> blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers