[Insight-developers] image information reset by gradient magnitude filter
Luis Ibanez
luis.ibanez at kitware.com
Thu Feb 5 11:38:27 EST 2009
Bill's fix has been committed now to the ITK 3.10 branch.
(along with the improved test).
Thanks
Luis
-----------------------
Gaëtan Lehmann wrote:
>
> Hi,
>
> Le 5 févr. 09 à 16:29, Bill Lorensen a écrit :
>
>> Luis,
>>
>> This error has always been present I believe.
>>
>> I reproduced the problem using CVS HEAD. I modified the filter's test
>> by adding non-default image information to the test input. Then, after
>> the filter runs, I compared the input and output image information.
>> Before my fix, the information differed. You can duplicate the failure
>> with my new test, if you comment out my fix (one line) and re-run the
>> test.
>>
>> This filter creates an internal image to accumulate results over each
>> dimension. Since the internal image never copied the image information
>> from the input image, the internal image had default settings for the
>> information. This internal image was used as the input to a mini
>> pipeline. The output of the internal mini-pipeline is grafted onto the
>> output of the filter.
>
>
> This design has not always been there. I have introduced it to add the
> multithreading support.
>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkGradientMagnitudeRecursiveGaussianImageFilter.txx?root=Insight&r1=1.18&r2=1.19
>
>
> The changes looked quite simple and not dangerous to me. The lack of
> failing test has comforted me in that opinion.
> That bug show that I was wrong.
>
> My apologies for that bug.
>
> Gaëtan
>
>
More information about the Insight-developers
mailing list